diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index ef8bf60efb..e5849bff5f 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -6,7 +6,10 @@ - Cards - new Cards UI. To migrate requires code changes from DG consuming devs. BUT silent support for "old" card syntax. Please check the documentation for more details. + - Silent support of the old UI until for the codebases who have not yet migrated their cards will be supported until the next major version release. - the new UI requires the introduction of new classes (.cards-cta, span.arrow, ...). Unless one of these new classes (`.cards-cta`) is present, then the old UI will be used, by checking conditionally `cards:has(.cards-cta)`. If your project does NOT support the :has() selector yet, but requires fallback support for the old UI, then add `.legacy` class to the `.cards` element. + - deprecated cards variants (.primary, .secondary, .tertiary) + - cards title text need to have the `.h4` class ## Technical changes diff --git a/src/App/ComponentsDocumentation/components/Card/constants.js b/src/App/ComponentsDocumentation/components/Card/constants.js index 976b5a98b2..0d87f51766 100644 --- a/src/App/ComponentsDocumentation/components/Card/constants.js +++ b/src/App/ComponentsDocumentation/components/Card/constants.js @@ -225,12 +225,12 @@ export const overviewCards = { }, }, { - name: "With image - 1/1 ratio", + name: "With image", value: { imgSrc: "https://design.swedbankpay.com/v/10.10.1/img/documentation/imagery/women-on-bus.svg", icon: null, - imgRatio: "ratio-1-1", + imgRatio: null, }, }, ], diff --git a/src/App/components/Cards/index.js b/src/App/components/Cards/index.js index d37ce65acb..84643f21d2 100644 --- a/src/App/components/Cards/index.js +++ b/src/App/components/Cards/index.js @@ -27,7 +27,6 @@ const Cards = ({ imgRatio, }) => ( <> - {/* TODO: set conditional ||