Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mount cloud storage in the storage mount dir #559

Merged
merged 5 commits into from
Dec 2, 2024
Merged

fix: mount cloud storage in the storage mount dir #559

merged 5 commits into from
Dec 2, 2024

Conversation

olevski
Copy link
Member

@olevski olevski commented Dec 2, 2024 •
edited
Loading

If the cloud storage target dir is not absolute then we mount relative to the storage directory.

/deploy

@olevski
fix: mount cloud storage in the storage mount dir
fb6bc83 
If the cloud storage target dir is not absolute then we mount relative
to the storage directory.
@olevski olevski requested a review from a team as a code owner December 2, 2024 08:32
@olevski olevski temporarily deployed to renku-ci-ds-559 December 2, 2024 08:40 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Dec 2, 2024

You can access the deployment of this PR at https://renku-ci-ds-559.dev.renku.ch

Panaetius
Panaetius previously approved these changes Dec 2, 2024
View reviewed changes
@coveralls
Copy link

coveralls commented Dec 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12117579810

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.03%) to 85.834%
Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/notebooks/blueprints.py 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_api/misc.py 1 98.36%
components/renku_data_services/crc/db.py 1 85.68%
components/renku_data_services/crc/blueprints.py 2 93.38%
components/renku_data_services/storage/blueprints.py 2 95.69%
components/renku_data_services/storage/models.py 2 84.11%
Totals Coverage Status
Change from base Build 12117399312: -0.03%
Covered Lines: 14493
Relevant Lines: 16885
💛 - Coveralls

@olevski olevski requested a review from Panaetius December 2, 2024 10:22
@olevski olevski merged commit a0eaa79 into main Dec 2, 2024
13 of 15 checks passed
@olevski olevski deleted the fix-mount-cloud-storage-in-storage-mount-dir branch December 2, 2024 12:52
@RenkuBot
Copy link
Contributor

RenkuBot commented Dec 2, 2024

Tearing down the temporary RenkuLab deplyoment for this PR.

olevski added a commit that referenced this pull request Dec 2, 2024
@olevski
fix: mount cloud storage in the storage mount dir (#559)
62a2ca4 
If the cloud storage target dir is not absolute then we mount relative
to the storage directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olevski @RenkuBot @coveralls @Panaetius