Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused code and properly serialize v1 servers #569

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

olevski
Copy link
Member

@olevski olevski commented Dec 10, 2024

This code is not used. For Renku v2 we are launching sessions with the new operator.

/deploy

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-569.dev.renku.ch

Panaetius
Panaetius previously approved these changes Dec 10, 2024
@coveralls
Copy link

coveralls commented Dec 10, 2024

Pull Request Test Coverage Report for Build 12273447605

Details

  • 15 of 16 (93.75%) changed or added relevant lines in 2 files are covered.
  • 18 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.7%) to 86.418%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/notebooks/blueprints.py 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/crc/db.py 1 85.46%
components/renku_data_services/crc/models.py 1 85.35%
components/renku_data_services/notebooks/api/amalthea_patches/git_proxy.py 1 86.21%
components/renku_data_services/notebooks/api/amalthea_patches/git_sidecar.py 1 85.0%
components/renku_data_services/notebooks/api/amalthea_patches/init_containers.py 2 65.43%
components/renku_data_services/notebooks/config/dynamic.py 2 93.16%
components/renku_data_services/crc/blueprints.py 3 93.69%
components/renku_data_services/notebooks/util/kubernetes_.py 7 56.86%
Totals Coverage Status
Change from base Build 12273418059: 0.7%
Covered Lines: 14621
Relevant Lines: 16919

💛 - Coveralls

@olevski olevski force-pushed the chore-remove-unused-code-to-20241210 branch from c7f510b to 0883537 Compare December 11, 2024 09:04
@olevski olevski force-pushed the chore-remove-unused-code-to-20241210 branch from 0883537 to 93d159b Compare December 11, 2024 09:11
@olevski olevski changed the title chore: remove Renku2UserServer code fix: remove unused code and properly serialize v1 servers Dec 11, 2024
@olevski olevski marked this pull request as ready for review December 11, 2024 09:23
@olevski olevski requested a review from Panaetius December 11, 2024 09:23
@olevski
Copy link
Member Author

olevski commented Dec 11, 2024

🤦 There seems to be some kind of request throttling that happens somewhere (I think in k3d) because locally the tests pass but here I see 429 too many requests. I will do a bit more digging.

@olevski
Copy link
Member Author

olevski commented Dec 11, 2024

🤦 There seems to be some kind of request throttling that happens somewhere (I think in k3d) because locally the tests pass but here I see 429 too many requests. I will do a bit more digging.

I cannot really replicate this.

Also the current tests are failing because the selenium acceptance tests need to access renkulab.io and they fail because prod is down. So I will merge this.

@Panaetius
Copy link
Member

we can always look into it more if it happens often

@olevski olevski merged commit 4bdb050 into main Dec 11, 2024
16 of 17 checks passed
@olevski olevski deleted the chore-remove-unused-code-to-20241210 branch December 11, 2024 12:18
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants