Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly validate docker image names #574

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: properly validate docker image names #574

merged 1 commit into from
Dec 11, 2024

Conversation

Panaetius
Copy link
Member

closes #551 (at least on the backend, still needs to be done on the frontend)

@Panaetius Panaetius requested a review from a team as a code owner December 11, 2024 13:09
olevski
olevski requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ralf two minor changes.

components/renku_data_services/session/api.spec.yaml Show resolved Hide resolved
test/bases/renku_data_services/data_api/test_sessions.py Show resolved Hide resolved
@Panaetius Panaetius force-pushed the validate-docker-names branch from 0240cfc to 96d096e Compare December 11, 2024 13:31
@olevski olevski self-requested a review December 11, 2024 13:32
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12277429492

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 86.388%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/crc/db.py 1 85.46%
components/renku_data_services/crc/models.py 1 84.71%
components/renku_data_services/crc/blueprints.py 4 92.74%
Totals Coverage Status
Change from base Build 12276207517: -0.04%
Covered Lines: 14616
Relevant Lines: 16919
💛 - Coveralls

@Panaetius Panaetius merged commit 27fe407 into main Dec 11, 2024
15 checks passed
@Panaetius Panaetius deleted the validate-docker-names branch December 11, 2024 13:56
@Panaetius Panaetius mentioned this pull request Dec 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olevski olevski olevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ContainerImage isn't validated in environments endpoints
3 participants
@Panaetius @coveralls @olevski