Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize dashboard components #2869

Closed
lorenzo-cavazzi opened this issue Oct 27, 2023 · 2 comments
Closed

Optimize dashboard components #2869

lorenzo-cavazzi opened this issue Oct 27, 2023 · 2 comments
Labels

Comments

@lorenzo-cavazzi
Copy link
Member

The sub-components in the Dashboard component are re-drawn from scratch every time the servers list updates, triggering a few APIs to fetch project details and commits. That's not necessary; be sure it won't happen again when adjusting the components.
Image

Bonus: we have separate sections and components in ProjectsDashboard for projects with and without running sessions. We should harmonize that so that projects don't temporarily disappear and re-appear when sessions terminate.

@leafty
Copy link
Member

leafty commented Dec 5, 2023

We want to better use the RTK query cache here, but this is going to be hard to do without refactoring the components used to display projects in the Dashboard.

Currently we gather all the projects' data before passing it down to rendering components, but this approach means that hitting cached will not happen when a session starts or gets deleted (change in the args used for the hooks).

The idiomatic approach is to let each component rendering a project entry to query its required data which would hit cache when available.

@lorenzo-cavazzi
Copy link
Member Author

This isn't worth the effort anymore since the current Dashboard will be phased out in the context of Renku 1.0

@lorenzo-cavazzi lorenzo-cavazzi closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Renku UI board Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants