Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes and empty list of data connectors secrets is sent to be saved #3394

Closed
leafty opened this issue Nov 11, 2024 · 0 comments · Fixed by #3400
Closed

Sometimes and empty list of data connectors secrets is sent to be saved #3394

leafty opened this issue Nov 11, 2024 · 0 comments · Fixed by #3400
Labels
bug

Comments

@leafty
Copy link
Member

leafty commented Nov 11, 2024 •
edited
Loading

Happens with S3/Switch storage.

Example: copy the DC from https://renkulab.io/v2/projects/renku-team/demo-project.
@leafty leafty added the bug label Nov 11, 2024
@leafty leafty changed the title Sometimes and empty list of data connectors secrets is sent to be saved. Sometimes and empty list of data connectors secrets is sent to be saved Nov 11, 2024
ciyer added a commit that referenced this issue Nov 15, 2024
@ciyer
fix: only save credentials when there are sensitive values (#3394)
bc0f3de 
Closes: #3394
@ciyer ciyer linked a pull request Nov 15, 2024 that will close this issue
Fix several minor data-connector bugs #3400
Merged
ciyer added a commit that referenced this issue Nov 15, 2024
@ciyer
fix: only save credentials when there are sensitive values (#3394)
d3d901d 
Closes: #3394
ciyer added a commit that referenced this issue Nov 18, 2024
@ciyer
Fix several minor data-connector bugs (#3394) (#3395) (#3400)
7b318bc 
* minor: fix DOM structure issue
* minor: use dropdown z-index for namespace select menu (#3395)
* fix: only save credentials when there are sensitive values (#3394)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix several minor data-connector bugs SwissDataScienceCenter/renku-ui
1 participant
@leafty