feat!: add support for session secrets in Renku 2.0 projects #3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leafty
changed the title
Merging into `build/session-secrets`. Add support for session secrets in Renku 2.0 projects. Session secrets can be managed from a project's settings page. * Add/Edit/Remove secret slots which describe where the secret is mounted in the session * Provide/Clear secret values so that the slot is populated in sessions --------- Co-authored-by: Chandrasekhar Ramakrishnan <[email protected]>
Ask logged-in users to provide missing session secrets at launch. The interrupt happens first, that is before the interrupt for data connector credentials.
Re-work user secrets:
* Split the "user secrets" page into v1 and v2 versions.
- `/secrets` lists secrets usable in Renku 1.0.
- `/v2/secrets` lists secrets usable in Renku 2.0 (all secrets).
* The `name` field does not have constraints, e.g. a secret can have "My Secret" as a name.
* A new field `default_filename` has been added for Renku 1.0 sessions.
* Secrets list the connected session secret slot and data connectors.
leafty
force-pushed
the
build/session-secrets
branch
from
2a9a7b6 to
f442910
Compare
Update the "Session Secrets" section to allow for the mount location to be configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work-in-progress feature branch. Closes #3412.
Content: