feat: data connectors on the project page #3334

ciyer · 2024-10-04T07:30:20Z

/deploy renku-data-services=leafty/build-data-connectors

RenkuBot · 2024-10-04T07:31:06Z

You can access the deployment of this PR at https://renku-ci-ui-3334.dev.renku.ch

* refactor: move data connector api to its own folder

leafty

Comments from manual testing:

When creating a new data connector from a project, the visibility is "private" by default, even on a public project.
When creating a data connector from a project page, using the "advanced mode" does not seem to work. I pasted the polybox config from dev.renku.ch but then the request sent to the backend only contained type = webdav and not the other fields.

leafty · 2024-10-09T12:26:22Z

client/public/crosshair.svg

Icons live in client/src/components/icons/.

Fixed in 4e0d010

leafty · 2024-10-09T12:31:33Z

client/src/features/dataConnectorsV2/components/DataConnectorActions.tsx

  isOpen: boolean;
  onDelete: () => void;
  toggleModal: () => void;
 }
-function DataConnectorDeleteModal({
+function DataConnectorRemoveModal({


I'm confused here. Why do we try to cram to different features inside the same component? It would be simpler imo to have <DataConnectorRemoveModal> and <DataConnectorUnlinkModal> be two separate modals. Then further down in the actions components you decide to display or not the modal and button. The code is already deciding on which text to write there.

Changed in 2b4eaab

client/src/features/dataConnectorsV2/components/DataConnectorView.tsx

leafty · 2024-10-09T12:41:10Z

client/src/features/dataConnectorsV2/components/DataConnectorView.tsx

 import DataConnectorActions from "./DataConnectorActions";
+import useDataConnectorProjects from "./useDataConnectorProjects.hook";
+
+function ConfigurationKeyIcon({ configKey }: { configKey: string }) {


Note: This component replaces simple one liners, e.g. <Database className={cx("bi", "me-1")} />. Therefore it does seem to increase complexity and reading.

We are going to remove all the icon stuff anyway, I would prefer to leave this as is in this PR and fix it in a later PR.

…iew.tsx Co-authored-by: Flora Thiebaut <[email protected]>

ciyer · 2024-10-10T15:20:11Z

Comments from manual testing:

When creating a new data connector from a project, the visibility is "private" by default, even on a public project.

Good point. I have fixed this in b1c7327.

When creating a data connector from a project page, using the "advanced mode" does not seem to work. I pasted the polybox config from dev.renku.ch but then the request sent to the backend only contained type = webdav and not the other fields.

I need to investigate this problem.

leafty

Great, thanks. Maybe we need to track the "advanced mode" issue.

ciyer · 2024-10-11T08:11:36Z

Maybe we need to track the "advanced mode" issue.

I think this is the right way forward. I was able to create a data connector using advanced mode, so it does sometimes work. I have created an issue for this: #3349

RenkuBot · 2024-10-11T09:23:14Z

Tearing down the temporary RenkuLab deplyoment for this PR.

* feat: support for data connectors on user and group namespaces (#3315) * feat: set/edit secrets for data connectors (#3330) * feat: data connectors on the project page (#3334) * feat: support launching sessions with data connectors (#3346) BREAKING CHANGE: Requires renku-data-services version >= 0.xx.0 BREAKING CHANGE: Requires renku-notebooks version >= 0.xx.0 build: update to latest project api spec

* feat: support for data connectors on user and group namespaces (#3315) * feat: set/edit secrets for data connectors (#3330) * feat: data connectors on the project page (#3334) * feat: support launching sessions with data connectors (#3346) * minor: cosmetic improvements to data connectors (#3359) BREAKING CHANGE: Requires renku-data-services version >= 0.xx.0 BREAKING CHANGE: Requires renku-notebooks version >= 0.xx.0

ciyer temporarily deployed to renku-ci-ui-3334 October 4, 2024 07:30 — with GitHub Actions Inactive

ciyer changed the base branch from main to build/data-connectors October 4, 2024 07:45

ciyer temporarily deployed to renku-ci-ui-3334 October 4, 2024 07:45 — with GitHub Actions Inactive

ciyer force-pushed the build/data-connectors branch from f70273a to 21bf381 Compare October 4, 2024 07:50

ciyer force-pushed the ciyer/project-data-connector branch from 7ddfdb6 to e70872c Compare October 4, 2024 09:58

ciyer temporarily deployed to renku-ci-ui-3334 October 4, 2024 09:58 — with GitHub Actions Inactive

ciyer temporarily deployed to renku-ci-ui-3334 October 4, 2024 14:35 — with GitHub Actions Inactive

ciyer had a problem deploying to renku-ci-ui-3334 October 7, 2024 20:27 — with GitHub Actions Failure

ciyer force-pushed the ciyer/project-data-connector branch from 9173b4d to 0ade890 Compare October 8, 2024 05:46

ciyer temporarily deployed to renku-ci-ui-3334 October 8, 2024 05:47 — with GitHub Actions Inactive

ciyer temporarily deployed to renku-ci-ui-3334 October 8, 2024 08:51 — with GitHub Actions Inactive

ciyer had a problem deploying to renku-ci-ui-3334 October 8, 2024 09:27 — with GitHub Actions Failure

ciyer force-pushed the ciyer/project-data-connector branch from 2ff0f92 to 24ad645 Compare October 9, 2024 08:39

ciyer had a problem deploying to renku-ci-ui-3334 October 9, 2024 08:39 — with GitHub Actions Failure

ciyer force-pushed the ciyer/project-data-connector branch from 24ad645 to c55f56d Compare October 9, 2024 09:02

ciyer temporarily deployed to renku-ci-ui-3334 October 9, 2024 09:02 — with GitHub Actions Inactive

ciyer force-pushed the ciyer/project-data-connector branch from c55f56d to 6907969 Compare October 9, 2024 09:45

ciyer temporarily deployed to renku-ci-ui-3334 October 9, 2024 09:46 — with GitHub Actions Inactive

ciyer force-pushed the build/data-connectors branch 2 times, most recently from e21198e to 21bf381 Compare October 9, 2024 10:10

feat: data connectors on project page

f9acac7

* refactor: move data connector api to its own folder

ciyer force-pushed the ciyer/project-data-connector branch from 6907969 to f9acac7 Compare October 9, 2024 10:11

ciyer temporarily deployed to renku-ci-ui-3334 October 9, 2024 10:12 — with GitHub Actions Inactive

ciyer marked this pull request as ready for review October 9, 2024 10:12

ciyer requested a review from a team as a code owner October 9, 2024 10:12

leafty reviewed Oct 9, 2024

View reviewed changes

Update client/src/features/dataConnectorsV2/components/DataConnectorV…

d8de0c4

…iew.tsx Co-authored-by: Flora Thiebaut <[email protected]>

ciyer had a problem deploying to renku-ci-ui-3334 October 10, 2024 13:00 — with GitHub Actions Failure

move crosshair icon to the icons folder

4e0d010

ciyer temporarily deployed to renku-ci-ui-3334 October 10, 2024 13:10 — with GitHub Actions Inactive

remove an intermediate component for deciding which remove modal to show

2b4eaab

ciyer had a problem deploying to renku-ci-ui-3334 October 10, 2024 14:45 — with GitHub Actions Failure

minor changes to unlink data dialog

436fdd9

ciyer had a problem deploying to renku-ci-ui-3334 October 10, 2024 14:49 — with GitHub Actions Failure

default new data connector visibility to project visibility

b1c7327

ciyer had a problem deploying to renku-ci-ui-3334 October 10, 2024 15:19 — with GitHub Actions Failure

fix lint problems

60b9688

ciyer had a problem deploying to renku-ci-ui-3334 October 10, 2024 15:27 — with GitHub Actions Failure

leafty approved these changes Oct 11, 2024

View reviewed changes

ciyer temporarily deployed to renku-ci-ui-3334 October 11, 2024 07:52 — with GitHub Actions Inactive

ciyer mentioned this pull request Oct 11, 2024

Renku 2.0: Sometimes cannot create data connectors in advanced mode #3349

Open

fix tests

3e960b1

ciyer deployed to renku-ci-ui-3334 October 11, 2024 08:35 — with GitHub Actions View deployment

ciyer merged commit 1de9bcd into build/data-connectors Oct 11, 2024
16 of 18 checks passed

ciyer deleted the ciyer/project-data-connector branch October 11, 2024 09:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: data connectors on the project page #3334

feat: data connectors on the project page #3334

ciyer commented Oct 4, 2024

RenkuBot commented Oct 4, 2024

leafty left a comment

leafty Oct 9, 2024

ciyer Oct 10, 2024

leafty Oct 9, 2024

ciyer Oct 10, 2024

leafty Oct 9, 2024

ciyer Oct 10, 2024

ciyer commented Oct 10, 2024

leafty left a comment

ciyer commented Oct 11, 2024

RenkuBot commented Oct 11, 2024

feat: data connectors on the project page #3334

feat: data connectors on the project page #3334

Conversation

ciyer commented Oct 4, 2024

RenkuBot commented Oct 4, 2024

leafty left a comment

Choose a reason for hiding this comment

leafty Oct 9, 2024

Choose a reason for hiding this comment

ciyer Oct 10, 2024

Choose a reason for hiding this comment

leafty Oct 9, 2024

Choose a reason for hiding this comment

ciyer Oct 10, 2024

Choose a reason for hiding this comment

leafty Oct 9, 2024

Choose a reason for hiding this comment

ciyer Oct 10, 2024

Choose a reason for hiding this comment

ciyer commented Oct 10, 2024

leafty left a comment

Choose a reason for hiding this comment

ciyer commented Oct 11, 2024

RenkuBot commented Oct 11, 2024