feat: make the session secret mount location configurable #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leafty
temporarily deployed
to
renku-ci-ui-3414
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-3414.dev.renku.ch |
leafty
temporarily deployed
to
renku-ci-ui-3414
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-3414
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-3414
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-3414
GitHub Actions
Inactive
leafty
force-pushed
the
leafty/session-secrets-3
branch
from
34c3b3f to
4f11abd
Compare
leafty
force-pushed
the
leafty/session-secrets-4
branch
from
db9b293 to
4efccde
Compare
leafty
temporarily deployed
to
renku-ci-ui-3414
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-3414
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-3414
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-3414
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-3414
GitHub Actions
Inactive
Base automatically changed from
leafty/session-secrets-3
to
build/session-secrets
December 10, 2024 12:48
leafty
force-pushed
the
build/session-secrets
branch
from
2a9a7b6 to
f442910
Compare
leafty
force-pushed
the
leafty/session-secrets-4
branch
from
947c8b1 to
7f289af
Compare
leafty
had a problem deploying
to
renku-ci-ui-3414
GitHub Actions
Failure
leafty
temporarily deployed
to
renku-ci-ui-3414
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-3414
GitHub Actions
Inactive
andre-code
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
It works really well! The code looks great, the interfaces are clean, and the UX is excellent. Great job, @leafty!
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3412, merging into
build/session-secrets.Update the "Session Secrets" section to allow for the mount location to be configured.
/deploy #notest renku=build/session-secrets renku-data-services=build/session-secrets