Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: nice-to-haves for the build #3416

Open
wants to merge 20 commits into
base: build/session-secrets
Choose a base branch
from
Open

feat: nice-to-haves for the build #3416

wants to merge 20 commits into from

Conversation

leafty
Copy link
Member

@leafty leafty commented Nov 28, 2024 •
edited
Loading

Part of #3412, merging into build/session-secrets.

Polishes the session secrets feature.

  • Launch interrupt for anon users
  • Re-designed user secrets page v2
  • Updated UI for session secrets and session secret slots
  • Ask for secret value after creating a new secret slot

Screenshot 2024-12-10 at 15 10 40
Screenshot 2024-12-10 at 15 11 16
Screenshot 2024-12-10 at 15 11 33

/deploy renku=build/session-secrets renku-data-services=build/session-secrets

@leafty leafty force-pushed the leafty/session-secrets-4 branch from db9b293 to 4efccde Compare December 2, 2024 13:32
@leafty leafty force-pushed the leafty/session-secrets-5 branch from 54f9349 to 153455c Compare December 3, 2024 08:09
@RenkuBot
Copy link
Contributor

RenkuBot commented Dec 3, 2024

You can access the deployment of this PR at https://renku-ci-ui-3416.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-ui-3416 December 3, 2024 09:52 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 3, 2024 11:59 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 3, 2024 13:39 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 3, 2024 13:50 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 4, 2024 13:31 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 4, 2024 13:42 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 4, 2024 14:14 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 4, 2024 15:41 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 5, 2024 09:27 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 6, 2024 09:23 — with GitHub Actions Inactive
@leafty leafty force-pushed the leafty/session-secrets-5 branch from d464a4b to 12010ba Compare December 6, 2024 12:30
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 6, 2024 12:30 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 9, 2024 09:24 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 9, 2024 09:51 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 9, 2024 10:25 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 10, 2024 12:04 — with GitHub Actions Inactive
This was referenced Dec 10, 2024
Merged
Draft
@leafty leafty force-pushed the leafty/session-secrets-4 branch from 947c8b1 to 7f289af Compare December 10, 2024 12:55
@leafty leafty force-pushed the leafty/session-secrets-5 branch from 0361a7d to 6df05f5 Compare December 10, 2024 13:06
@leafty leafty force-pushed the leafty/session-secrets-5 branch from 973434e to 16d3a03 Compare December 10, 2024 13:32
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 10, 2024 13:32 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 10, 2024 13:57 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3416 December 10, 2024 14:12 — with GitHub Actions Inactive
Base automatically changed from leafty/session-secrets-4 to build/session-secrets December 11, 2024 09:37
@leafty leafty force-pushed the leafty/session-secrets-5 branch from 584798e to 871674c Compare December 11, 2024 09:38
@leafty leafty marked this pull request as ready for review December 11, 2024 09:39
@leafty leafty requested a review from a team as a code owner December 11, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leafty @RenkuBot