fix: make the pre-populated quota large enough #3419
Conversation
leafty
temporarily deployed
to
renku-ci-ui-3419
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-3419.dev.renku.ch |
leafty
temporarily deployed
to
renku-ci-ui-3419
GitHub Actions
Inactive
| () => | ||
| defaultSessionClass | ||
| ? { | ||
| cpu: 2 * defaultSessionClass.cpu, |
There was a problem hiding this comment.
Why are we multiplying by two here? Shouldn't we simply use the default quota value? Alternatively, consider defining this multiplier as a separate constant with a self-explanatory name to clarify its purpose.
There was a problem hiding this comment.
These values are supposed to be changed by the admin to configure the resource pool anyway. The code makes sure that the values for the quota are higher than the values for the class, otherwise the backend will send back a 422 error. Using a 1x multiplier would allow only one session to ever be launched, so that looked too low.
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Fixes #3417.
Manually tested, working as intended.
/deploy