feat: group page design #3428
Open
feat: group page design #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre-code
changed the base branch from
main
to
andrea/add-new-dashboard-layout
andre-code
had a problem deploying
to
renku-ci-ui-3428
GitHub Actions
Error
andre-code
temporarily deployed
to
renku-ci-ui-3428
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-3428.dev.renku.ch |
andre-code
force-pushed
the
andrea/group-page
branch
from
933b301 to
816c479
Compare
andre-code
temporarily deployed
to
renku-ci-ui-3428
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/group-page
branch
from
816c479 to
44902d2
Compare
andre-code
temporarily deployed
to
renku-ci-ui-3428
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/group-page
branch
from
44902d2 to
49c14e1
Compare
andre-code
temporarily deployed
to
renku-ci-ui-3428
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/add-new-dashboard-layout
branch
from
8492b99 to
a88b823
Compare
andre-code
force-pushed
the
andrea/group-page
branch
from
49c14e1 to
76c6751
Compare
andre-code
temporarily deployed
to
renku-ci-ui-3428
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-3428
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/group-page
branch
from
76c6751 to
5c89a04
Compare
andre-code
temporarily deployed
to
renku-ci-ui-3428
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/group-page
branch
from
5c89a04 to
9ef2c8a
Compare
andre-code
temporarily deployed
to
renku-ci-ui-3428
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/group-page
branch
from
9ef2c8a to
b891a8e
Compare
andre-code
had a problem deploying
to
renku-ci-ui-3428
GitHub Actions
Failure
andre-code
temporarily deployed
to
renku-ci-ui-3428
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/group-page
branch
from
b891a8e to
406e7d4
Compare
leafty
reviewed
Dec 11, 2024
Comment on lines
+27
to
+32
| const watermarkStyles: CSSProperties = { | ||
| right: "0", | ||
| fontSize: "150px", | ||
| lineHeight: "0", | ||
| color: "rgba(0, 0, 0, 0.1)", | ||
| }; |
There was a problem hiding this comment.
Please use bootstrap classnames and SCSS modules.
right: "0"->end-0from bootstrap- others can go in a SCSS module
| const type = `${storage?.configuration?.type?.toString() ?? ""} ${ | ||
| storage?.configuration?.provider?.toString() ?? "" | ||
| }`; | ||
| const readOnly = storage?.readonly ? ( |
There was a problem hiding this comment.
This will prevent the element from being computed when extendedPreview is false.
Suggested change
| const readOnly = storage?.readonly ? ( | |
| const readOnly = extendedPreview && (storage?.readonly ? ( |
| <span className="fw-bold" data-cy="data-connector-name"> | ||
| {name} | ||
| </span> | ||
| <div |
There was a problem hiding this comment.
This seems to take too much vertical space:
| "align-items-center" | ||
| )} | ||
| > | ||
| <UserAvatar username={namespace} size={UserAvatarSize.small} /> |
There was a problem hiding this comment.
nitpick: the initials go green when hovering.
| errors={errors} | ||
| name="slug" | ||
|
|
||
| <PermissionsGuard |
There was a problem hiding this comment.
I think this should be "delete" permission, to be checked.
| }; | ||
| return ( | ||
| <ContainerWrap className="position-relative"> | ||
| <EntityWatermark type="group" /> |
There was a problem hiding this comment.
This is broken at smaller viewports:
How to fix it:
<ContainerWrap> // remove "relative"
<EntityWatermark type="group" />With EntityWatermark being:
<div className="position-relative">
<div className="position-absolute top-0 end-0">
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to apply redesign to group page
/deploy renku=andrea/update-dashboard-layout renku-data-services=andrea/fix-total-groups-in-all-group