feat: add user page design #3433
Open
+101
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre-code
temporarily deployed
to
renku-ci-ui-3433
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-3433.dev.renku.ch |
andre-code
force-pushed
the
andrea/user-page-redesign
branch
from
91824ab to
34ab475
Compare
andre-code
had a problem deploying
to
renku-ci-ui-3433
GitHub Actions
Failure
andre-code
temporarily deployed
to
renku-ci-ui-3433
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/group-page
branch
from
5c89a04 to
9ef2c8a
Compare
andre-code
force-pushed
the
andrea/user-page-redesign
branch
from
34ab475 to
64bc54b
Compare
andre-code
had a problem deploying
to
renku-ci-ui-3433
GitHub Actions
Failure
andre-code
force-pushed
the
andrea/user-page-redesign
branch
from
64bc54b to
5376abb
Compare
andre-code
temporarily deployed
to
renku-ci-ui-3433
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/group-page
branch
from
9ef2c8a to
b891a8e
Compare
andre-code
force-pushed
the
andrea/user-page-redesign
branch
from
5376abb to
0898a36
Compare
andre-code
had a problem deploying
to
renku-ci-ui-3433
GitHub Actions
Failure
andre-code
temporarily deployed
to
renku-ci-ui-3433
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/group-page
branch
from
b891a8e to
406e7d4
Compare
andre-code
force-pushed
the
andrea/user-page-redesign
branch
from
0898a36 to
1ad0ec1
Compare
leafty
reviewed
Dec 12, 2024
| const information = ( | ||
| <div className={cx("d-flex", "flex-column", "gap-3")}> | ||
| <div> | ||
| <p className={cx("align-items-center", "d-flex", "gap-2", "mb-0")}> |
There was a problem hiding this comment.
Just use me-2 on the Icon, all these classes are not needed except mb-0.
Also, I don't think using a p element is appropriate here since the semantic flow is broken. The whole Identifer: <username> should be found inside a single p if possible. Otherwise just use <div> and <span>.
| </section> | ||
| return ( | ||
| <ContainerWrap className="position-relative"> | ||
| <EntityWatermark type="user" /> |
There was a problem hiding this comment.
This may be broken just like for groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply new user page design
/deploy renku=andrea/update-dashboard-layout renku-data-services=andrea/fix-total-groups-in-all-group