Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update jupyter base #126

Merged
merged 12 commits into from
Mar 4, 2021
Merged

chore: update jupyter base #126

merged 12 commits into from
Mar 4, 2021

Conversation

rokroskar
Copy link
Member

@rokroskar rokroskar commented Oct 15, 2020

Updates the base image to an updated jupyter base-notebook image which means a different version of ubuntu and python.

To verify:

  • python image
  • R image
  • cuda

@rokroskar rokroskar force-pushed the 000-update-jupyter-base branch 2 times, most recently from d8eccfd to b92a04b Compare October 16, 2020 10:16
@ableuler
Copy link
Contributor

python image seems to work fine!

@ableuler ableuler added this to the sprint-2020-10-22 milestone Oct 22, 2020
@rokroskar rokroskar force-pushed the 000-update-jupyter-base branch from 1596e8d to b405294 Compare March 2, 2021 15:54
@olevski
Copy link
Member

olevski commented Mar 4, 2021

@rokroskar I can confirm that the fix for the cuda-tf image works.

One thing I saw is that the cuda.9.2 image (without tensorflow) is not part of the makefile. Should we fully get rid of this? Or I think it may be better to include the part that installs cuda from the cuda-tf image and make it a standalone cuda image without tf? Then the cuda-tf image can start with the cuda-only image. And the cuda-only image can be there for anyone who needs it - i.e. people who use pytorch.

Also it is ok with me if we address what I suggest her into a separate issue/pr.

@rokroskar
Copy link
Member Author

Thanks for checking @olevski! Good point about cuda-9.2 - afaik no one uses that anymore so we should remove it, but lets do it in a follow-up PR

@rokroskar
Copy link
Member Author

actually I didn't fully read what you wrote :) Also +1 on having a cuda image without TF.

@olevski olevski self-requested a review March 4, 2021 14:17
@olevski
Copy link
Member

olevski commented Mar 4, 2021

Here is a new issue for the cuda without tensorflow image: #141

@rokroskar rokroskar merged commit b4d0d83 into master Mar 4, 2021
@rokroskar rokroskar deleted the 000-update-jupyter-base branch March 4, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants