-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update jupyter base #126
Conversation
d8eccfd
to
b92a04b
Compare
python image seems to work fine! |
1596e8d
to
b405294
Compare
@rokroskar I can confirm that the fix for the cuda-tf image works. One thing I saw is that the cuda.9.2 image (without tensorflow) is not part of the makefile. Should we fully get rid of this? Or I think it may be better to include the part that installs cuda from the cuda-tf image and make it a standalone cuda image without tf? Then the cuda-tf image can start with the cuda-only image. And the cuda-only image can be there for anyone who needs it - i.e. people who use pytorch. Also it is ok with me if we address what I suggest her into a separate issue/pr. |
Thanks for checking @olevski! Good point about cuda-9.2 - afaik no one uses that anymore so we should remove it, but lets do it in a follow-up PR |
actually I didn't fully read what you wrote :) Also +1 on having a cuda image without TF. |
Here is a new issue for the cuda without tensorflow image: #141 |
Updates the base image to an updated jupyter base-notebook image which means a different version of ubuntu and python.
To verify: