Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Uniprot annotations for all genes #320

Closed
3 of 4 tasks
edkerk opened this issue Jun 5, 2022 · 5 comments · Fixed by #349
Closed
3 of 4 tasks

feat: Uniprot annotations for all genes #320

edkerk opened this issue Jun 5, 2022 · 5 comments · Fixed by #349
Assignees
Labels
fixed in devel this issue is already fixed in devel and will be closed after the next release

Comments

@edkerk
Copy link
Member

edkerk commented Jun 5, 2022

Description of the issue:

Add Uniprot annotations in model.geneMiriams (see identifiers.org) for all genes. Use the S288c reference proteome as source, providing one Uniprot ID per gene.

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Done this analysis in the main branch of the repository
  • Checked that a similar issue does not exist already
  • If needed, asked first in the Gitter chat room about the issue
@hongzhonglu
Copy link
Collaborator

hongzhonglu commented Jun 6, 2022

Hi Ed, what is detailed annotation, only the Uniprot ID per gene?

@edkerk
Copy link
Member Author

edkerk commented Jun 6, 2022

Indeed, this has recently been done nicely for new genes that @cheng-yu-zhang has been introducing (example, uniprot column), having this for all genes would be useful, particular with ec-models in mind.

@hongzhonglu
Copy link
Collaborator

I see. It looks great.

@edkerk
Copy link
Member Author

edkerk commented Jun 9, 2022

Looking at the information that can be parsed from Uniprot, this can probably quite easily be implemented.

@edkerk edkerk self-assigned this Jun 9, 2022
@cheng-yu-zhang
Copy link
Collaborator

cheng-yu-zhang commented Jul 24, 2023

I will think about it.

@edkerk edkerk linked a pull request Oct 16, 2023 that will close this issue
1 task
@edkerk edkerk added the fixed in devel this issue is already fixed in devel and will be closed after the next release label Oct 16, 2023
@edkerk edkerk closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in devel this issue is already fixed in devel and will be closed after the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants