Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker 19.x is not recognized #21

Open
mwvaughn opened this issue Aug 7, 2019 · 4 comments
Open

Docker 19.x is not recognized #21

mwvaughn opened this issue Aug 7, 2019 · 4 comments
Assignees
Labels
bug Something isn't working test please Need help validating a feature or fix
Milestone

Comments

@mwvaughn
Copy link

mwvaughn commented Aug 7, 2019

The abaco deploy workflow checks the major version reported by docker --version to detect a workable Docker installation. The CLI is intended for use with Docker CE 17+. However, the Docker Desktop is shipping Docker version 19.03 as of 8/1/2019 and that is not interpreted correctly by abaco deploy

@mwvaughn mwvaughn added the bug Something isn't working label Aug 7, 2019
@mwvaughn mwvaughn added this to the v1.3.0 milestone Aug 7, 2019
@mwvaughn mwvaughn self-assigned this Aug 7, 2019
@mwvaughn
Copy link
Author

mwvaughn commented Aug 7, 2019

Resolved in 893bbac - as an aside, there has to be a smarter pure-Bash way of interpreting version strings than what we have written.

@mwvaughn mwvaughn closed this as completed Aug 7, 2019
@mwvaughn
Copy link
Author

Reopening to test

@mwvaughn mwvaughn reopened this Aug 13, 2019
@mwvaughn mwvaughn added the test please Need help validating a feature or fix label Aug 13, 2019
@mwes
Copy link

mwes commented Dec 14, 2020

@mwes and @georgebzheng are seeing issues with the latest docker build (~version 20), we'll workaround for now locally. This will likely affect others as they upgrade to Docker engine 20.10.0+

@mwvaughn
Copy link
Author

mwvaughn commented Dec 14, 2020

Fixed in master and v1.3.1 in commit 2217e3a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test please Need help validating a feature or fix
Projects
None yet
Development

No branches or pull requests

2 participants