Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-182: adding additional logging for project uuid upon deletion #163

Merged
merged 3 commits into from
Nov 30, 2023
Merged

task/WG-182: adding additional logging for project uuid upon deletion #163

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74232d3
adding addtional logging for project uuid upon deletion
Nov 29, 2023
73cadc8
fixing linting issue
Nov 29, 2023
580e3d5
changing logging message from UUID to project_uuid and removing 404 c…
Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions geoapi/routes/projects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,15 @@ def get(self, projectId: int):
@project_admin_or_creator_permissions
def delete(self, projectId: int):
u = request.current_user
logger.info("Delete project:{} for user:{}".format(projectId,
u.username))
return ProjectsService.delete(db_session, u, projectId)
# Retrieve the project using the projectId to get its UUID
project = ProjectsService.get(db_session, project_id=projectId, user=u)
# Check if the project exists and log the information including the UUID
if project:
logger.info("Delete project:{} with UUID:{} for user:{}".format(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of UUID what about project_uuid?

There are lots of uuids in the code for things like task, streetview, asset path etc. so maybe being more specific would improve things.

I got the somewhat related PR #161 where I did something different but I am going to alter that to match what we decide here and the rest of the code.

Seems like the rest of the log statements use project: when referring to the int id 👍 so just what should we call the project uuid.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change it to "Project UUID:" or "project_uuid:"

projectId, project.uuid, u.username))
return ProjectsService.delete(db_session, u, projectId)
else:
abort(404, "Project not found")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good thought on adding a check related to the project not being found. but it can be dropped in this instance as the project_admin_or_creator_permissions decorator has that logic in a check_access_and_get_project method that it calls.


@api.doc(id="updateProject",
description="Update metadata about a project")
Expand Down
Loading