Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_client_url to include react deployments #214

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Aug 28, 2024

Overview:

React app was failing on deployed environments (one frontend fix was needed here) and here we update the get_client_url so it knows about the react deployments.

PR Status:

  • Ready.

Related Jira tickets:

relates to TACC-Cloud/hazmapper#252

Testing Steps:

  1. Visit https://hazmapper.tacc.utexas.edu/dev-react

Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tested in the dev site against a new map, image embed and accessing the same map in the react client.

@nathanfranklin nathanfranklin merged commit b345f37 into main Aug 31, 2024
3 checks passed
@nathanfranklin nathanfranklin deleted the task/WG-373-fix-deployed-react-app branch August 31, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants