[feature request] Debugger break on unlogged opcode execution

[nesrocks]

Request: Add a toggle for breaking execution when encountering an unlogged opcode (as in the code/data logger logs).
Why: When reverse engineering games this would be very useful for detecting new branches in code. Play around in a section of the game with CD on, then turn on the "break on unlogged opcode" toggle, and then execute the new action.

[mjbudd77]

Would you want this to break on unclogged code and data separately? One selection for break on unclogged code and one for break on unclogged data?

[nesrocks]

Having a sepparate option for "break on unlogged code" and "break on unlogged byte read" would be very useful.
By the way, it is fine to have this on a dropdown menu in the debugger, it doesn't have to be directly accessible on the debugger UI which already has too many items.

[mjbudd77]

I've added the code for this to the Qt GUI. In addition, I have fixed a couple items you had mentioned in the nes dev thread. Namely, I added the cd display characters to the debugger assembly view and added code for most of the debug and tools windows to remember their positioning. Please try out the qfceux.exe from the appveyor build at the commit seen above.

[warmCabin]

Added to win32 as well.

[mjbudd77]

@nesrocks can you please provide feedback? Please do your testing on the Qt GUI, I don’t think the changes have actually made it to the Win32 master branch

[warmCabin]

That's right, Win32 development is still ongoing. You should be able to grab the latest build from AppVeyor if you want to test that version. I added a dropdown for those break_on_xxx flags you made, mjbudd.

[nesrocks]

@nesrocks can you please provide feedback? Please do your testing on the Qt GUI, I don’t think the changes have actually made it to the Win32 master branch

I'm sorry just after making this request I got word from the publisher that my game that I had been working on for 4 years was about to be released on consoles, which means a lot of work that needs to be done fast. I did test it though and it did seem to have a few issues. Just never had the time to test more so I could write down a consistent list of issues. I hope to have enough time to do this soon.