Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make publication title usernames clickable #1094

Open
Masterjun3 opened this issue Feb 10, 2022 · 0 comments
Open

Make publication title usernames clickable #1094

Masterjun3 opened this issue Feb 10, 2022 · 0 comments
Labels
enhancement Priority: Low User-Facing Issue that is very low priority Publication System

Comments

@Masterjun3
Copy link
Collaborator

(Put this as Super Future milstone and like lowest priority.)
This can be considered a regression from the old site, where you could actually click the player link in publications (if the player was assigned a page).

However, actually implementing this is currently a bigger task than it might seem.
For performance and processing reasons, the title of publications and submissions is stored as a string in the DB. So instead of having to do several DB calls and then formatting the title, it just pulls it once and displays it. This makes a big difference on those huge movie lists.
And because it's just a string, you can't just attempt to randomly parse usernames and turn them into links for the html.

So maybe the design regarding titles needs to be reworked.
Or maybe this needs to be limited to certain small pages, maybe the impact mentioned above isn't so big then.

@adelikat adelikat added the Priority: Bottom Not important. If you can fix anything else, you should. But not bad if you do. label Jul 10, 2022
@Masterjun3 Masterjun3 added Priority: Low User-Facing Issue that is very low priority and removed Priority: Bottom Not important. If you can fix anything else, you should. But not bad if you do. labels Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Priority: Low User-Facing Issue that is very low priority Publication System
Projects
None yet
Development

No branches or pull requests

4 participants