Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Create new Device": Errorhandling incorrect #2

Open
mrentsch65 opened this issue May 30, 2019 · 2 comments
Open

"Create new Device": Errorhandling incorrect #2

mrentsch65 opened this issue May 30, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@mrentsch65
Copy link

  1. Create new Device with incorrect ProductID or VendorID (string instead of number)
  2. Errormessage correctly show that the values must be numbers
  3. Message dialog "Successfully created device!" appears, which should not be the case.
@DorianSnowball
Copy link
Member

DorianSnowball commented Jun 3, 2019

The Errormessage states "Vendor ID is in an ivalid Format (Expected only numbers)! Ignoring!".
Since the ProductID and the VendorID are not required for the device, the device will be created and the invalid input is ignored.

You are able to update the productID and VendorID afterwards using the Plugin.

tldr: This is intended.

@mrentsch65
Copy link
Author

Ok, I see it is intended behaviour. But from usability viewpoint it is misleading. Could we change the error message to "Warning: Vendor ID must be a number. Please correct input." The create process should only be startable with correct (or empty optional) inputs. Can we also change the subsequent message "Successfully created device!" to "Device description file created!"?

@DorianSnowball DorianSnowball added the enhancement New feature or request label Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants