Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support libadalang23 #5

Open
willem66745 opened this issue Nov 16, 2022 · 2 comments
Open

Support libadalang23 #5

willem66745 opened this issue Nov 16, 2022 · 2 comments

Comments

@willem66745
Copy link

I tried to build against libadalang23. That results in a build failure:

extraction-primitive_subps.adb:14:35: error: invalid use of subtype mark in expression or call
extraction-primitive_subps.adb:37:35: error: invalid use of subtype mark in expression or call

Appears that libadalang has changed LALCO.Ada_Type_Decl to a range. I changed Node.Kind = LALCO.Ada_Type_Decl into Node.KInd in LALCO.Ada_Type_Decl. Is this correct?

@pjljvandelaar
Copy link
Collaborator

Libadalang did indeed change Ada_Type_Decl.
Using in instead of = seems indeed the right solution.

We currently have no plans in updating to libadalang 23.0, but we will look into this issue when we will move to a newer version of libadalang.

@pjljvandelaar
Copy link
Collaborator

Of course, the answer it at (the documentation of) libadalang:

  • if they just divided Ada_Type_Decl up into sub categories then in is correct.
  • if they added elements to Ada_Type_Decl then = old_element is correct.
  • if they splitted and added elements to Ada_Type_Decl then in <range of old_elements> is correct

However, in the last two cases, it might be that the dependency graph extractor wanted more elements than libadalang did provide and this change enables that:
in that case in <range of relevent_elements> would be the preferred solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants