Feature/mdc to material ui #288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added MDC icons src script to index.html * Adjusted all mdc-* classes for Material UI in Catalog Card and Catalog components * Adjusted scss files for Material-UI class changes where necessary
* Moved spread op of prevState before declaration of showButton to avoid overwrite, causing scrollTop button to never show * Fixed some performance issues caused by above state management issue
Made some progress on MaterialUI ToolDrawer today. Primary concerns noticed today include migrating from class components to functional components; MaterialUI is almost completely functional and plays better with functional components. By extention, the functional components also use Hooks rather than the old class-based life cycles. Finally, the components take advantage of functional, hook-based cssInJS styling, which will need to factor in to this migration plan as well. Progress outlined below: * Moving toward hook-based components in stateless components like CollectionSorter * Migrated ToolDrawer classes to MaterialUI components * Migrating scss classes to use the makeStyles() hook from MaterialUI
* Continued to transition ToolDrawer and its child components to Material-UI. * Transitioned CatalogCard to functional component * Still working on resolving url and CollectionFilter checkboxes to consistent state on page reloads, etc
Lots of changes here
* Refactored catalog.jsx to functional component, reducing by ~80 lines of code. Migrating scss to cssInJs file in dedicated folder
* Refactored loading animation into separate component <SweetLoadingScreen/> that can be used in anywhere in app
* CollectionTimeslider.jsx -> functional component, -> MaterialUI
* ToolDrawer.jsx to functional component, migrated cssInJs to separate file in {root} ./cssInJs
* Implemented onChangeCommitted method in collectionTimeslider.jsx so that filter is not executed until the slider is released. Local slider state still uses onChange. Makes for smoother UI experience uninterrupted by re-renders caused by change in props.visibleCollections
* Migrated Toast / Snackbar to MaterialUI and implemented with functional components and React Hooks.
* Mid-migration on several other sub-components in Catalog View, including the ShareButtons component
* More changes than listed here, but generally covers most changes. Nearly capable of being PR'd for a review.
Contains multiple class -> function refactors and some cleanup
|
closing this for now, but keeping the feature branch in case we can use this in the future rebuild. the plan is to still switch over to material UI if it makes sense, but it should probably wait until later in the rebuild project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to partially resolve #271, a continual migration effort from mdc-web-components to Material-UI. Migrations also touch on transitions
Note that the themeChooser component has been temporarily removed from the toolDrawer until all styles have been migrated from scss to cssInJs using the makeStyles / createMuiTheme hooks.