Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional --ignore-overlaps to ivar #30

Closed
priesgo opened this issue Oct 31, 2022 · 1 comment
Closed

Add optional --ignore-overlaps to ivar #30

priesgo opened this issue Oct 31, 2022 · 1 comment

Comments

@priesgo
Copy link
Member

priesgo commented Oct 31, 2022

Spin off feature request from #28

@priesgo
Copy link
Member Author

priesgo commented Nov 19, 2022

Original request was referring to BU-ISCIII/viralrecon#14 and andersen-lab/ivar#104. The first one is related to variants in overlapping read pairs, while the second one is related to overlapping variants.

Starting with the second, the issue of overlapping variants is dealt with differently in CoVigator. We annotate the variants with VAFator and then only use for the consensus sequence those with VAF >= 0.8, we do not use ivar consensus but bcftools consensus. In any case, the overlapping variants reported in the ivar issue look funny, isn't that an insertion and a SNV? If that is the case they do not overlap.

About the first of overlapping reads. This issue of different Phred qualities is reported on samtools 1.8, we use 1.12. I went through the samtools release notes here https://github.com/samtools/samtools/releases and could not find any reference to this issue being fixed. In any case in #37 I added several options to add optional arguments into the variants calling process such as --args_ovar_samtools='--ignore-overlaps'

@priesgo priesgo closed this as completed Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant