Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File overwriten without warning as multiple files with same destination filename possible #791

Open
NePoCz opened this issue May 31, 2021 · 0 comments

Comments

@NePoCz
Copy link

NePoCz commented May 31, 2021

Thanks everyone contributing for this great tool, it makes things so much easier. Here is a bug/undesired behaviour discovered (the hard way...) during usage.

Bug Details

Describe the bug
If two versions of the same episode exist in the destination folder (with same extension) and rename is enabled, then both will be renamed to the same filename, meaning one of them will be overwritten as a result

Expected Behaviour
Ideally, prevent multiple operations with same resulting file name with a warning message. Or there should be warning/confirmation that two files will end up with the same name as a result of "Do Checked" action. Or at least do not autocheck these file as default, if conflicts are detected.

Current Behaviour
Two "rename" actions with same destination file name are performed without warning, resulting in file overwrite.

To Reproduce
Manually rename 2-part episode files to S01E01.xxx.cd1.mp4 & S01E01.xxx.cd2.mp4. Scan the show, leave all things checked as default and perform "Do Checked". Result will be only S01E01.xxx.mp4 and the other file will be overwritten.

Context
I understand that TV-Rename currently does not support multipart episodes (i.e. S01E01.xxx.cd1.mp4 + S01E01.xxx.cd2.mp4), without manually adding a "new" episode as the second part in "Edit Season". But if you decide to do this manually (for the rare case), during the next scan and action, TV-Rename will rename the two files into the same file name, effectively deleting one, without any warning.

Version: 4.2.4. Alpha 24
(also tested on latest stable v3.3.1 with same results)

  • Operating System: Windows 10
  • Are you using the windows version or command line version? Windows version

XML Files

I believe this is configuration-independent, except for the "Scan Settings --> Rename check" (system wide) or "Edit Show --> Advanced --> Do renaming" (per show). Both of them are only workarounds, since they disable renaming altogether.

Log Files

Log Extract (redacted)
...|INFO| Identified that S:\MASH\Season 10\M#A#S#H - S10E01 - That's Show Biz.cd1.mkv should be renamed to M#A#S#H - S10E01 - That's Show Biz.mkv.
...|INFO| Identified that S:\MASH\Season 10\M#A#S#H - S10E01 - That's Show Biz.cd2.mkv should be renamed to M#A#S#H - S10E01 - That's Show Biz.mkv.
.
(redacted)
.
...|INFO| Rename completed: S:\MASH\Season 10\M#A#S#H - S10E01 - That's Show Biz.cd1.mkv to S:\MASH\Season 10\M#A#S#H - S10E01 - That's Show Biz.mkv
...|INFO| Rename completed: S:\MASH\Season 10\M#A#S#H - S10E01 - That's Show Biz.cd2.mkv to S:\MASH\Season 10\M#A#S#H - S10E01 - That's Show Biz.mkv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant