Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(angular-query): injectQueries #8007

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat(angular-query): injectQueries #8007

wants to merge 6 commits into from
+377 −125

Conversation

Arthie
Copy link
Contributor

@Arthie Arthie commented Sep 2, 2024 •
edited
Loading

Noticed injectQueries had yet to be fully implemented, this is my attempt to get it working.
Did some limited testing, and added simple test cases that are all passing.

Looking for feedback.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 2, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b7315dc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 2, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8007

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8007

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8007

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8007

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8007

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8007

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8007

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8007

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8007

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8007

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8007

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8007

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8007

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8007

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8007

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8007

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8007

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8007

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8007

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8007

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8007

commit: b7315dc

@codecov Codecov
Copy link

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.62%. Comparing base (102b6a8) to head (b7315dc).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #8007       +/-   ##
=========================================
+ Coverage      0   94.62%   +94.62%     
=========================================
  Files         0       18       +18     
  Lines         0      279      +279     
  Branches      0       41       +41     
=========================================
+ Hits          0      264      +264     
- Misses        0       14       +14     
- Partials      0        1        +1
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 94.62% <94.44%> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
---- 🚨 Try these New Features:

@arnoud-dv
Copy link
Collaborator

That's great, finishing injectQueries is one of the major pieces of work remaining. I'll review it but may be a few days.

@Timebutt
Copy link

I just pulled this branch into my project since I needed the injectQueries functionality, and found it non-functional in the current implementation in main. Is this something we can get reviewed so that it could make its way into the main branch? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: angular-query-experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arthie @arnoud-dv @Timebutt