- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(start): update cloudflare-pages
deployment instructions
#2744
Conversation
Hi @SeanCassiere. Could you review this change once you have time please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested these changes on my personal project and can confirm that these changes fixes the deployment.
cloudflare-pages
deployment instructions
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7163162. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Thank you for this contribution @xstevenyung! Also, thanks to @Talent30 for bringing this to my attention. |
…ack#2744) Co-authored-by: Sean Cassiere <33615041+SeanCassiere@users.noreply.github.com>
it seems like nitro and therefore vinxi rely on
node:async_context
to run. while cloudflare doesn't have support for the required API to make this work. the nitro team has started working on this on their packageunenv
in tacked this issueuntil this is integrated in nitro, we need to manually point to the latest version of
unenv
in theapp.config.ts
:i've updated the hosting documentation to include this and also remove the build command that was attached as it's not possible to pass an unenv via the CLI
related issues:
nitrojs/nitro#1943
solidjs/solid-start#1527
#2633 (comment)