Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router-generator): initial route template should return JSX #2856

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

SeanCassiere
Copy link
Member

Closes #2814

Changes the route template in the generator from returning:

return 'Hello /foo/!'

To now return valid JSX:

return <div>Hello "/foo/"!</div>

Copy link

nx-cloud bot commented Nov 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 41d6dc4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@SeanCassiere SeanCassiere marked this pull request as ready for review November 25, 2024 20:54
Copy link

pkg-pr-new bot commented Nov 25, 2024

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@2856

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@2856

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@2856

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@2856

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@2856

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@2856

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@2856

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@2856

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@2856

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@2856

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@2856

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@2856

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@2856

@tanstack/start-vite-plugin

npm i https://pkg.pr.new/@tanstack/start-vite-plugin@2856

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@2856

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@2856

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@2856

commit: 41d6dc4

@SeanCassiere SeanCassiere merged commit 0e8c0a5 into main Nov 25, 2024
5 checks passed
@SeanCassiere SeanCassiere deleted the generator/route-should-return-jsx branch November 25, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudflare build fails if routes/index.tsx is replaced by vinxi dev server automatically
1 participant