Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Feat(#272): 메인페이지 반응형 작업 #290

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Conversation

JeongWuk
Copy link
Collaborator

📑 구현 사항

  • 메인페이지 반응형 작업
Steady.-.Brave.2023-11-29.17-03-25.mp4

🚧 특이 사항

  • 필터 모달 안에서 SingleSelector 선택창이 안뜹니다...
  • 인증되지 않은 사용자가 필터 모달 안에서 내 좋아요를 누르면 로그인 알림 모달이 띄워지게 했는데 모달이 즉시 사라지는 현상이 생깁니다...

🚨관련 이슈

close #272

@JeongWuk JeongWuk self-assigned this Nov 29, 2023
@JeongWuk JeongWuk added 기능 새로운 기능! 🚨 D-0 당일 리뷰 부탁드립니다! labels Nov 29, 2023
@JeongWuk JeongWuk added this to the 6차 스프린트 milestone Nov 29, 2023
Copy link
Member

@sscoderati sscoderati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당

@@ -47,7 +48,7 @@ import { steadyRunningMethods } from "@/constants/selectorItems";
const Home = () => {
const { page, setPage } = usePageStore();
const [like, setLike] = useState(false);
const [recruit, setRecruit] = useState(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -687,6 +701,115 @@ const Home = () => {
</div>
</div>
<StickyButton onClick={() => ChannelIO.showMessenger()} />
<Sheet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 그런데 원래 있는 코드와 중복이 많은 것 같아요... 추후에 별도의 컴포넌트로 분리하시죠!

src={item.profileImage}
alt="profile"
radius="full"
className="h-20 w-20 cursor-pointer md:flex md:h-25 md:w-25"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1:1 비율을 유지하도록 aspect-square 속성을 추가하시는건 어떨까요?

@JeongWuk JeongWuk merged commit 4ab2986 into main Nov 30, 2023
2 checks passed
@JeongWuk JeongWuk deleted the feat/#272/mainpage branch November 30, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
기능 새로운 기능! 🚨 D-0 당일 리뷰 부탁드립니다!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] - Main Page 반응형 작업
2 participants