Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#99 [hotfix] : 중복되는 네이밍 에러 수정 #100

Merged
merged 2 commits into from
Oct 12, 2024
Merged

#99 [hotfix] : 중복되는 네이밍 에러 수정 #100

merged 2 commits into from
Oct 12, 2024

Conversation

chanubc
Copy link
Member

@chanubc chanubc commented Oct 11, 2024 •
edited
Loading

✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁

  • merge할 브랜치의 위치를 확인해 주세요(main❌/develop⭕)
  • 리뷰가 필요한 경우 리뷰어를 지정해 주세요
  • P1 단계의 리뷰는 필수로 반영합니다.
  • Approve된 PR은 assigner가 머지하고, 수정 요청이 온 경우 수정 후 다시 push를 합니다.

📌 𝗜𝘀𝘀𝘂𝗲𝘀

📎𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻

  • 중복 네이밍 에러 수정
  • named arguments 지정
  • top bar 로직 수정

📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁

💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀

@chanubc chanubc added the 🚑️ [HOTFIX] 이슈나 QA에서 발생된 급하게 해결해야 될 문제 label Oct 11, 2024
@chanubc chanubc requested a review from a team October 11, 2024 15:49
@chanubc chanubc self-assigned this Oct 11, 2024
@chanubc chanubc requested review from Eonji-sw and sohyun127 and removed request for a team October 11, 2024 15:49
@chanubc chanubc added the 🐻 찬우 차은우 label Oct 11, 2024
@chanubc chanubc merged commit a2f3037 into develop Oct 12, 2024
1 check passed
@chanubc chanubc deleted the hotfix/#99-naming-error branch October 12, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohyun127 sohyun127 sohyun127 approved these changes

@Eonji-sw Eonji-sw Awaiting requested review from Eonji-sw Eonji-sw was automatically assigned from Team-Wable/wable-android

Assignees

@chanubc chanubc

Labels
🐻 찬우 차은우 🚑️ [HOTFIX] 이슈나 QA에서 발생된 급하게 해결해야 될 문제
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[HOTFIX] : 네이밍 에러 수정
2 participants
@chanubc @sohyun127