Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/#113] news탭 compose setting #114

Merged
merged 7 commits into from
Nov 23, 2024
Merged

[Feature/#113] news탭 compose setting #114

merged 7 commits into from
Nov 23, 2024

Conversation

chanubc
Copy link
Member

@chanubc chanubc commented Nov 23, 2024 •
edited
Loading

✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁

  • merge할 브랜치의 위치를 확인해 주세요(main❌/develop⭕)
  • 리뷰가 필요한 경우 리뷰어를 지정해 주세요
  • P1 단계의 리뷰는 필수로 반영합니다.
  • Approve된 PR은 assigner가 머지하고, 수정 요청이 온 경우 수정 후 다시 push를 합니다.

📌 𝗜𝘀𝘀𝘂𝗲𝘀

📎𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻

  • news탭 compose setting
  • NewsInfoModel

📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁

image

💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀

Dto는 달라도 NewsInfoModel은 공지사항에서 사용되는 model이랑 같아서 공통으로 써도 될거 같은데 네이밍만 바꿔서 같이 쓸까요?

@chanubc chanubc added ⭐ [FEAT] 새로운 기능 구현 🐻 찬우 차은우 ☕ [COMPOSE] 컴포즈 ui labels Nov 23, 2024
@chanubc chanubc requested a review from a team November 23, 2024 18:02
@chanubc chanubc self-assigned this Nov 23, 2024
@chanubc chanubc requested review from Eonji-sw and sohyun127 and removed request for a team November 23, 2024 18:02
Eonji-sw
Eonji-sw approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@Eonji-sw Eonji-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chanubc chanubc merged commit 1905715 into develop Nov 23, 2024
1 check passed
@chanubc chanubc deleted the feature/#113-news-compose-setting branch November 23, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eonji-sw Eonji-sw Eonji-sw approved these changes

@sohyun127 sohyun127 Awaiting requested review from sohyun127 sohyun127 was automatically assigned from Team-Wable/wable-android

Assignees

@chanubc chanubc

Labels
☕ [COMPOSE] 컴포즈 ui ⭐ [FEAT] 새로운 기능 구현 🐻 찬우 차은우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] : 뉴스 모듈 컴포즈 세팅
2 participants
@chanubc @Eonji-sw