[Feature/#105] : 대댓글 UI, API #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohyun127
requested review from
a team,
Eonji-sw and
chanubc
and removed request for
a team
chanubc
approved these changes
Nov 25, 2024
| @@ -14,7 +14,7 @@ import retrofit2.http.Path | |||
| import retrofit2.http.Query | |||
|
|
|||
| interface CommentService { | |||
| @GET("api/v2/content/{contentId}/comments") | |||
| @GET("api/v3/content/{contentId}/comments") | |||
There was a problem hiding this comment.
앗 이거 저희 쪽에서 v3로 새로 함수 만들어서 쓴다고 착각했네요
근데 지금 로그아웃 하고 로그인이 안되서
이전 버전(v1) 으로 dto포함 로그인 돌리면 되긴합니다만
내일 서버와 이야기 해보아야 할것 같아요!
There was a problem hiding this comment.
아하!! 로그인 api v2로 업하고 체크를 못했네요 서버랑 이야기 해볼게요!
Eonji-sw
reviewed
Nov 25, 2024
| @@ -12,7 +12,7 @@ interface CommentRepository { | |||
|
|
|||
| suspend fun deleteComment(commentId: Long): Result<Unit> | |||
|
|
|||
| suspend fun postComment(contentId: Long, commentText: String): Result<Unit> | |||
| suspend fun postComment(contentId: Long, commentInfo: Triple<String, Long, Long>): Result<Unit> | |||
There was a problem hiding this comment.
Zzzzzzzzㅋㅋㅋㅋㅋㅋㅋㅋㅋ
| @@ -28,7 +30,7 @@ internal class DefaultCommentRepository @Inject constructor( | |||
| getNextCursor = { comments -> comments.lastOrNull()?.commentId }, | |||
| ) | |||
| }.flow.map { pagingData -> | |||
| pagingData.map { it.toComment() } | |||
| pagingData.flatMap { it.toComments() } | |||
There was a problem hiding this comment.
P3 : flatMap 이런 것도 잇군요? 내장 코드 활용 넘 잘하는 ㄷㄷ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
default.mp4
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀
comment edit text 커서 변경하는 김에 posting 쪽 커서도 변경했습니다. 883afa8 커밋 참고해주세요!