[Fix/#130] : 1차 스프린트 2차 QA 반영 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohyun127
requested review from
a team,
Eonji-sw and
chanubc
and removed request for
a team
chanubc
approved these changes
Nov 27, 2024
Comment on lines
+4
to
21
| private val lastCalls = mutableMapOf<String, Long>() | ||
|
|
||
| fun debounce( | ||
| delayTime: Long = DEBOUNCE_DELAY, | ||
| coroutineScope: CoroutineScope, | ||
| event: () -> Unit, | ||
| ) { | ||
| if (::debounceJob.isInitialized) debounceJob.cancel() | ||
| debounceJob = coroutineScope.launch { | ||
| delay(delayTime) | ||
| event() | ||
| fun canProceed(key: String): Boolean { | ||
| val currentTime = System.currentTimeMillis() | ||
| val lastCallTime = lastCalls[key] ?: 0L | ||
| return if (currentTime - lastCallTime >= THROTTLE_DELAY) { | ||
| lastCalls[key] = currentTime | ||
| true | ||
| } else { | ||
| false | ||
| } | ||
| } | ||
|
|
||
| companion object { | ||
| private const val DEBOUNCE_DELAY = 200L | ||
| private const val THROTTLE_DELAY = 2000L | ||
|
|
||
| fun from(): SingleEventHandler = SingleEventHandler() | ||
| } |
There was a problem hiding this comment.
thorttle 보단 싱글 클릭에 가깝다고 생각이 되서 저도 한번 테스트 해보고 말씀드려 볼게요!
There was a problem hiding this comment.
흠 싱글클릭이 최선인 것 같습니다
throttle을 flow랑 라이프사이클로 구현했는데 뷰의생명주기를 따라가야해서 어쩔수 없네요..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
20241127_215432.mp4
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
comment dialog, hidekeyboard
KakaoTalk_20241127_221536004.mp4
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀