Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs #202

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix docs #202

merged 1 commit into from
Aug 26, 2024

Conversation

shinich1
Copy link
Contributor

Before submitting, please check the following:

  • Make sure you have tests for the new code and that test passes (run tox)
  • If applicable, add a line to the [unreleased] part of CHANGELOG.md, following keep-a-changelog.
  • Format added code by ruff
    • See CONTRIBUTING.md for more details

Then, please fill in below:

Context (if applicable):
Fix docs build failures.

Description of the change:
I have also updated pr template to ask for docs build as part of local pr checks.

Related issue:

also see that checks (github actions) pass.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.25%. Comparing base (633eac8) to head (f958d99).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   76.24%   76.25%   +0.01%     
==========================================
  Files          36       36              
  Lines        5724     5724              
==========================================
+ Hits         4364     4365       +1     
+ Misses       1360     1359       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shinich1 shinich1 merged commit d4d2f5d into master Aug 26, 2024
21 checks passed
@shinich1 shinich1 deleted the docs-fix branch August 26, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant