Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start enforcing typecheck #211

Merged
merged 13 commits into from
Sep 13, 2024
Merged

Start enforcing typecheck #211

merged 13 commits into from
Sep 13, 2024

Conversation

EarlMilktea
Copy link
Contributor

Description of the change:

Use mypy and pyright to detect type warnings.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.98%. Comparing base (ad18270) to head (2c00304).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
graphix/types.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   76.91%   76.98%   +0.06%     
==========================================
  Files          38       38              
  Lines        5979     5984       +5     
==========================================
+ Hits         4599     4607       +8     
+ Misses       1380     1377       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EarlMilktea EarlMilktea marked this pull request as ready for review September 12, 2024 05:57
Copy link
Contributor

@thierry-martinez thierry-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! However, I think we can remove the disabled error code.

requirements.txt Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@thierry-martinez
Copy link
Contributor

LGTM! Thanks.

Copy link
Contributor

@shinich1 shinich1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! let's squash and merge.

@EarlMilktea EarlMilktea merged commit f534634 into master Sep 13, 2024
23 checks passed
@EarlMilktea EarlMilktea deleted the typecheck branch September 13, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants