Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Pauli and related modules #228

Merged
merged 61 commits into from
Nov 4, 2024
Merged

Refactor Pauli and related modules #228

merged 61 commits into from
Nov 4, 2024

Conversation

EarlMilktea
Copy link
Contributor

Description of the change:

  • change module structures to resolve circular import
  • introduce Pauli namespace
  • cleanup duplication
  • add tests

@EarlMilktea
🧑‍💻 Annotate
77f7fb1
@EarlMilktea
🚚 Define is_integer
08c0892
@EarlMilktea
🚧 Refactor pauli.py
2d03e9a
@EarlMilktea
✅ Update tests
0a142e0
@EarlMilktea
🔧 Check pauli.py
408e330
@EarlMilktea
🚚 Create measurements.py
e768295
@EarlMilktea
🚚 Update symbols
87a8b31
@EarlMilktea
🚨 Fix linter warnings
ab36a0c
@EarlMilktea
🚚 Create test_command.py
5330392
@EarlMilktea
🔧 Check test_command.py
1607ab1
@EarlMilktea
🔧 Change glob pattern
978f782
@EarlMilktea
🚨 Resolve linter warnings
781e013
@EarlMilktea
🚚 Move to fundamentals.py to resolve circular imports
be6faee
@EarlMilktea
🧑‍💻 Resolve test name conflict
39cb128
@EarlMilktea
🚸 Enhance generality
22fd4a4
@EarlMilktea
♻️ Change iteration order
ab5b05a
@EarlMilktea
✅ Add tests
2561dd6
@EarlMilktea
🚧 Update fundamentals.py
e439ffe
@EarlMilktea
✅ Test fundamentals.py
cfe4395
@EarlMilktea
🔧 Check new files
3627d4b
@EarlMilktea
🚸 Use .matrix for consistency
55e958e
@EarlMilktea
♻️ Remove get_
99d987f
@EarlMilktea
🚚 Change filename
e85b828
@EarlMilktea
📝 Update module docstring
a6443e4
@EarlMilktea
✨ Update utils.py
0522171
@EarlMilktea
♻️ Remove WellKnownMatrix
0f9f85b
@EarlMilktea
♻️ Reuse enums
d645c8c
@EarlMilktea
✨ Add try_from_matrix
e0b75bb
@EarlMilktea
✅ Update test
41f5f38
@EarlMilktea
🔧 Change file name
98d5a22
shinich1
shinich1 reviewed Oct 24, 2024
View reviewed changes
docs/source/data.rst Outdated Show resolved Hide resolved
shinich1
shinich1 reviewed Oct 24, 2024
View reviewed changes
graphix/measurements.py Outdated Show resolved Hide resolved
@shinich1
Copy link
Contributor

@thierry-martinez

shinich1
shinich1 reviewed Oct 31, 2024
View reviewed changes
graphix/pauli.py Outdated Show resolved Hide resolved
thierry-martinez
thierry-martinez requested changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@thierry-martinez thierry-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good improvement! Thanks! I made some minor comments.

graphix/command.py Outdated Show resolved Hide resolved
graphix/_db.py Show resolved Hide resolved
graphix/clifford.py Outdated Show resolved Hide resolved
graphix/clifford.py Outdated Show resolved Hide resolved
graphix/pauli.py Outdated Show resolved Hide resolved
graphix/pauli.py Show resolved Hide resolved
graphix/pauli.py Outdated Show resolved Hide resolved
graphix/sim/base_backend.py Outdated Show resolved Hide resolved
tests/test_statevec_backend.py Outdated Show resolved Hide resolved
tests/test_statevec_backend.py Outdated Show resolved Hide resolved
thierry-martinez
thierry-martinez requested changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@thierry-martinez thierry-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. There are still two uses of cached_property that don’t appear to be necessary.

graphix/_db.py Show resolved Hide resolved
graphix/fundamentals.py Outdated Show resolved Hide resolved
graphix/fundamentals.py Outdated Show resolved Hide resolved
thierry-martinez
thierry-martinez approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@thierry-martinez thierry-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@EarlMilktea EarlMilktea merged commit 7da2095 into master Nov 4, 2024
23 checks passed
@EarlMilktea EarlMilktea deleted the refactor-pc branch November 4, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinich1 shinich1 shinich1 approved these changes

@thierry-martinez thierry-martinez thierry-martinez approved these changes

Assignees

@EarlMilktea EarlMilktea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EarlMilktea @shinich1 @thierry-martinez