-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor BaseM
#237
base: master
Are you sure you want to change the base?
Refactor BaseM
#237
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #237 +/- ##
=======================================
Coverage 78.99% 78.99%
=======================================
Files 40 40
Lines 6113 6114 +1
=======================================
+ Hits 4829 4830 +1
Misses 1284 1284 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
I opened this PR to respect your initial motivation to introduce In addition to that, I have the following suggestion:
I feel it's clearer to use |
LGTM! Thanks. The purpose of |
class BaseM: | ||
"""Base class for measurement command. | ||
|
||
This class does not contain any data except for the node to measure. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation added in commit ad18270 and later deleted in #205 was more informative. I believe we should revert to that version.
class BaseM: | |
"""Base class for measurement command. | |
This class does not contain any data except for the node to measure. | |
""" | |
class BaseM: | |
"""Base measurement command. | |
Represent a measurement of a node. In MBQC, a measure is an instance of `M`, | |
with given plane, angles, and domains. In the context of blind computations, | |
the server only knows which node is measured, and the parameters are given | |
by the :class:`graphix.simulator.MeasureMethod` provided by the client. | |
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intentionally trimmed them to ensure that no outdated info. is left.
Of course willing to revert to the original after discussion.
As far as I remember we didn't agree on anything regarding measurement commands. Was it even raised as an issue? The structure Furthermore, your PR message
is cryptic and it would be best to be more precise in the future. |
I opened this PR to improve this structure itself before aggressively refactoring simulators. |
Context (if applicable):
Related to #178 .
Description of the change: (WIP)
BaseM