Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles appear twice sometimes #11204

Open
6 tasks done
helloyanis opened this issue Jun 23, 2024 · 7 comments
Open
6 tasks done

Subtitles appear twice sometimes #11204

helloyanis opened this issue Jun 23, 2024 · 7 comments
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background) youtube Service, https://www.youtube.com/

Comments

@helloyanis
Copy link

helloyanis commented Jun 23, 2024

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.27.0

Steps to reproduce the bug

  1. Open a video with colored subtitles such as this one
  2. Turn on subtitles for "English (United Kingdom)"

Expected behavior

The subtitles display correctly, like on the official youtube app as shown below
Screenshot_20240623_082128_YouTube

Actual behavior

The subtitles' color and tempo is correct, but they appear twice, as shown below
Screenshot_20240623_082312_NewPipe

Screenshots/Screen recordings

Screen_Recording_20240623_083520_NewPipe.mp4

Logs

No response

Affected Android/Custom ROM version

Android 14 / Stock rom

Affected device model

Samsung Galaxy A52s 5G

Additional information

No response

@helloyanis helloyanis added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Jun 23, 2024
@opusforlife2
Copy link
Collaborator

Hmmm. This is occurring on Piped and Invidious too.

@opusforlife2 opusforlife2 added player Issues related to any player (main, popup and background) and removed needs triage Issue is not yet ready for PR authors to take up labels Jun 23, 2024
@haoyeau
Copy link

haoyeau commented Oct 19, 2024

After debugging on this case, we found out that the decoded subtitle input stream indeed contain duplicate subtitle text. Therefore, this should be a subtitle extractor issue. And the player is totally good for rendering subtitle.

@helloyanis
Copy link
Author

After debugging on this case, we found out that the decoded subtitle input stream indeed contain duplicate subtitle text. Therefore, this should be a subtitle extractor issue. And the player is totally good for rendering subtitle.

So should I open the issue elsewhere instead?

@haoyeau
Copy link

haoyeau commented Oct 19, 2024

Sorry, I do not know it either.
I traced back the stream info to get the subtitle
As you can see clearly from this, the subtitle itself is duplicated.

@Thompson3142
Copy link
Contributor

This is already open as an issue on the extractor side: TeamNewPipe/NewPipeExtractor#1102 . Not sure if this issue should be closed since it also needs work on the NewPipe side to function after the extractor changes @opusforlife2 .

@helloyanis
Copy link
Author

This is already open as an issue on the extractor side: TeamNewPipe/NewPipeExtractor#1102 . Not sure if this issue should be closed since it also needs work on the NewPipe side to function after the extractor changes @opusforlife2 .

I think I'll keep it open here until it's fixed in NewPipe. Even if it depends on something else it's still an issue that occurs in the app. I'll close it once the extractor is updated and is fixed in newpipe.

@ShareASmile ShareASmile added the youtube Service, https://www.youtube.com/ label Oct 30, 2024
@opusforlife2
Copy link
Collaborator

Normally, an issue that also needs changes in the extractor is labelled as such and left open. In this case, the extractor itself contains the bug, so NPE users like Piped are also affected. I do not know whether there need to be changes made to the app as well after the extractor is fixed, so I'd keep this open to be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background) youtube Service, https://www.youtube.com/
Projects
None yet
Development

No branches or pull requests

5 participants