Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of the maximum "What's new"-tab backlog from 500 to 1000 possible tiles #11741

Open
6 tasks done
Plugdemholes-Imeanpatchdembugs opened this issue Nov 23, 2024 · 2 comments
Labels
feature request Issue is related to a feature in the app feed Issue is related to the feed

Comments

@Plugdemholes-Imeanpatchdembugs

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Hi :)
I've noticed, the first time ever after a months of absence from my tablet that the feed backlog is limited to 500 tiles, so I currently can't see the other two weeks. It's very rare occasion I guess but could the feed be extended to a maximum of 1000 tiles if possible? :)

Why do you want this feature?

I can't see the rest of the videos that were uploaded in one month of absence, the maximum tiles of 500 "recent" uploads were exceeded. :)

Additional information

no further remarks

@Plugdemholes-Imeanpatchdembugs Plugdemholes-Imeanpatchdembugs added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Nov 23, 2024
@Plugdemholes-Imeanpatchdembugs Plugdemholes-Imeanpatchdembugs changed the title Extension of the maximum "What's new"-tab backlog from 500 to 1000 tiles Extension of the maximum "What's new"-tab backlog from 500 to possible 1000 tiles Nov 23, 2024
@Plugdemholes-Imeanpatchdembugs Plugdemholes-Imeanpatchdembugs changed the title Extension of the maximum "What's new"-tab backlog from 500 to possible 1000 tiles Extension of the maximum "What's new"-tab backlog from 500 to 1000 possible tiles Nov 23, 2024
@TobiGr
Copy link
Member

TobiGr commented Nov 23, 2024

This is the limit you are talking about, I guess:

ORDER BY s.upload_date IS NULL DESC, s.upload_date DESC, s.uploader ASC
LIMIT 500
"""
)
abstract fun getStreams(
groupId: Long,
includePlayed: Boolean,
includePartiallyPlayed: Boolean,
uploadDateBefore: OffsetDateTime?
): Maybe<List<StreamWithState>>

It is there to keep the query fast and memory usage low. I think we could even reduce the limit to ~200 because it is unusual to look further back. Especially because the feed only contains streams that were published in the last 13 weeks. Instead we could implement lazy loading more items when reaching the end of the displayed list.

@TobiGr TobiGr added feed Issue is related to the feed and removed needs triage Issue is not yet ready for PR authors to take up labels Nov 23, 2024
@Plugdemholes-Imeanpatchdembugs
Copy link
Author

Plugdemholes-Imeanpatchdembugs commented Nov 23, 2024

This would be awesome! :)
I myself didn't think I'd ever have to load in so many videos at once. But here I am with my ~170 subscriptions and look and see it's a backlog of more than 500 in just one month. ^^"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app feed Issue is related to the feed
Projects
None yet
Development

No branches or pull requests

2 participants