Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Refactored Identifiers" #1242

Merged
merged 1 commit into from
Nov 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public abstract class Extractor {
@Nullable
private ContentCountry forcedContentCountry = null;

private boolean isPageFetched = false;
private boolean pageFetched = false;
// called like this to prevent checkstyle errors about "hiding a field"
private final Downloader downloader;

Expand All @@ -54,21 +54,21 @@ public LinkHandler getLinkHandler() {
* @throws ExtractionException if the pages content is not understood
*/
public void fetchPage() throws IOException, ExtractionException {
if (isPageFetched) {
if (pageFetched) {
return;
}
onFetchPage(downloader);
isPageFetched = true;
pageFetched = true;
}

protected void assertPageFetched() {
if (!isPageFetched) {
if (!pageFetched) {
throw new IllegalStateException("Page is not fetched. Make sure you call fetchPage()");
}
}

protected boolean isPageFetched() {
return isPageFetched;
return pageFetched;
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public final class AudioStream extends Stream {

// Fields for DASH
private int itag = ITAG_NOT_AVAILABLE_OR_NOT_APPLICABLE;
private int bitRate;
private int bitrate;
private int initStart;
private int initEnd;
private int indexStart;
Expand Down Expand Up @@ -351,7 +351,7 @@ private AudioStream(@Nonnull final String id,
this.itagItem = itagItem;
this.itag = itagItem.id;
this.quality = itagItem.getQuality();
this.bitRate = itagItem.getBitrate();
this.bitrate = itagItem.getBitrate();
this.initStart = itagItem.getInitStart();
this.initEnd = itagItem.getInitEnd();
this.indexStart = itagItem.getIndexStart();
Expand All @@ -369,8 +369,8 @@ private AudioStream(@Nonnull final String id,
* {@inheritDoc}
*/
@Override
public boolean areStatsEqual(final Stream cmp) {
return super.areStatsEqual(cmp) && cmp instanceof AudioStream
public boolean equalStats(final Stream cmp) {
return super.equalStats(cmp) && cmp instanceof AudioStream
&& averageBitrate == ((AudioStream) cmp).averageBitrate
&& Objects.equals(audioTrackId, ((AudioStream) cmp).audioTrackId)
&& audioTrackType == ((AudioStream) cmp).audioTrackType
Expand Down Expand Up @@ -405,8 +405,8 @@ public int getItag() {
*
* @return the bitrate set from the {@link ItagItem} passed in the constructor of the stream.
*/
public int getBitRate() {
return bitRate;
public int getBitrate() {
return bitrate;
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public static boolean containSimilarStream(final Stream stream,
return false;
}
for (final Stream cmpStream : streamList) {
if (stream.areStatsEqual(cmpStream)) {
if (stream.equalStats(cmpStream)) {
return true;
}
}
Expand All @@ -97,7 +97,7 @@ public static boolean containSimilarStream(final Stream stream,
* @param other the stream object to be compared to this stream object
* @return whether the stream have the same stats or not, based on the criteria above
*/
public boolean areStatsEqual(@Nullable final Stream other) {
public boolean equalStats(@Nullable final Stream other) {
if (other == null || mediaFormat == null || other.mediaFormat == null) {
return false;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,8 @@ public boolean isAutoGenerated() {
* {@inheritDoc}
*/
@Override
public boolean areStatsEqual(final Stream cmp) {
return super.areStatsEqual(cmp)
public boolean equalStats(final Stream cmp) {
return super.equalStats(cmp)
&& cmp instanceof SubtitlesStream
&& code.equals(((SubtitlesStream) cmp).code)
&& autoGenerated == ((SubtitlesStream) cmp).autoGenerated;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,8 @@ private VideoStream(@Nonnull final String id,
* {@inheritDoc}
*/
@Override
public boolean areStatsEqual(final Stream cmp) {
return super.areStatsEqual(cmp)
public boolean equalStats(final Stream cmp) {
return super.equalStats(cmp)
&& cmp instanceof VideoStream
&& resolution.equals(((VideoStream) cmp).resolution)
&& isVideoOnly == ((VideoStream) cmp).isVideoOnly;
Expand Down
Loading