-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a topic outline to have participants "Practice the PR Review Process" #2069
Comments
Please assign me to this issue @daaimah123 |
Congratulations on becoming a contributor! 🎉 I have assigned the issue to you, @ChasVanDav |
After our conversation this afternoon on Slack, I am clear on the lesson itself and I am working on creating a pull request. Thank you! @daaimah123 |
Keeping the issue context in this thread in case others need to follow along outside of private Slack messages. You requested clarification about the following:
This portion of the issue is asking you to create a written statement (possibly that lives in a section with a header called "overview" or "real-life application") that explains how the activity is similar to the PR feedback process and that in that process simulation they will discover the importance of reading other people's code |
thank you for the clarification @daaimah123 ! |
@ChasVanDav I am noticing your PR is still in draft mode and no additional commits have been pushed up; please provide an update on the status of this issue, by 8:30am PT tomorrow. |
@daaimah123 This issue will be addressed by early next week! I am dealing with an eye infection and have to stay away from screens for a couple of days. Thank you for checking in and please allow the extra time to get this handled. |
This should be an interactive lesson with two activities whereby participants are practicing their PR Review Process. Please make clear that this lesson should be implemented by participants on a Monday or Tuesday of week 8.
The participants will also be building an application (Game with API) during week 8, to learn how to fetch API data this week concurrently. As such there should be mention of the following:
Activity 1:
Have each of the participants get started with the exercise by having them add their name to this file. The PR should include the following:
Activity 2:
Have each participant interactively participate in the PR Review Process by creating a pull request on their feedback partner's full stack code from the previous week (week 7), and reviewing incoming changes to their own work.
Repo Owner:
Collaborator:
Activity 3:
Each pull request owner must address their PR feedback in a tangible, but visible way:
Page where issue should live
Add the lesson here.
Type of problem
We want participants to practice reading full stack application source code that isn't their own and having the capacity to articulate how logic is broken down.
Suggested Solution
Add an overview or application statement that discusses the activity simulating a PR review process, and allowing for practice reading pre-existing code the person didn't write themselves.
Acceptance Criteria
Supplemental Resources
The text was updated successfully, but these errors were encountered: