Code improvements

Tectu · Nov 25, 2024 · a7e02e0 · a7e02e0
1 parent 3831721
commit a7e02e0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/lib/malloy/core/detail/controller_run_result.hpp b/lib/malloy/core/detail/controller_run_result.hpp
@@ -32,7 +32,8 @@ namespace malloy::detail
         {
             if (!logger)
                 throw std::logic_error{"invalid config: logger is null"};
-            else if (num_threads == 0)
+
+            if (num_threads == 0)
                 throw std::logic_error{"invalid config: cannot have 0 threads"};
         };
     };

diff --git a/lib/malloy/core/utils.hpp b/lib/malloy/core/utils.hpp
@@ -54,8 +54,8 @@ namespace malloy
     [[nodiscard]]
     static
     inline
-    uint8_t
-    hex2dec(uint8_t c)
+    std::uint8_t
+    hex2dec(std::uint8_t c)
     {
         if (c >= '0' && c <= '9')
             c -= '0';

diff --git a/lib/malloy/server/http/connection_detector.cpp b/lib/malloy/server/http/connection_detector.cpp
@@ -32,6 +32,7 @@ class router_adaptor :
      *
      * @param router The router.
      */
+    explicit
     router_adaptor(router_t router) :
         m_router{ std::move(router) }
     {