Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NodeJS Email Sender #129

Closed
wants to merge 3 commits into from
Closed

Add NodeJS Email Sender #129

wants to merge 3 commits into from

Conversation

ahmadfaizan965
Copy link

Description

  • A NodeJS app to send emails.

Add GIF/ScreenShot

  • Screenshot added in README

Task Checklist

Put x in between the square brackets without any spaces to tick your Task. Create a PR only after you complete all the tasks.

  • You have created a new branch for contribution.
  • Added README.md for your project in a specified folder.
  • Add Demo in GIF or Screenshot form.
  • You are Registered Officially for HacktoberFest 2021 as Partcipant.
  • Followed Contribution Guidelines.

Issue

Mention your issue no.: #127

soumikbaithalu
soumikbaithalu requested changes Oct 18, 2021
View reviewed changes
Copy link
Member

@soumikbaithalu soumikbaithalu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minnor changes

  • also checkout from the master and then make a PR.

NodeJS Email Sender/app.js Outdated
})
app.listen(3000, function(){
console.log("Server's up & running at port 3000.");
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line at EOF.

NodeJS Email Sender/index.html Outdated
</div>
</body>

</html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line at EOF

NodeJS Email Sender/public/styles.css Outdated
margin:10px;
width: 100%;
margin: 5px;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new line at EOF.

@soumikbaithalu soumikbaithalu linked an issue Oct 18, 2021 that may be closed by this pull request
NodeJS email sender #127
Open
@ahmadfaizan965
Copy link
Author

changes made.

@ahmadfaizan965
Copy link
Author

kindly approve it so that i can initiate some more PRs. Otherwise it will count one in Hacktoberfest.

soumikbaithalu
soumikbaithalu requested changes Oct 19, 2021
View reviewed changes
Copy link
Member

@soumikbaithalu soumikbaithalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change is to be done checkout from the master branch created newbranch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumikbaithalu soumikbaithalu soumikbaithalu requested changes

Assignees

@ahmadfaizan965 ahmadfaizan965

Labels
Assigned easy enhancement New feature or request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NodeJS email sender
2 participants
@ahmadfaizan965 @soumikbaithalu