Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xz/luxor tensor plot #44

Merged
merged 9 commits into from
Aug 4, 2024
Merged

Conversation

ArrogantGao
Copy link
Contributor

@ArrogantGao ArrogantGao commented Aug 2, 2024

Add the viz tool LuxorTensorPlot as an extension of the OMEinsumContractionOrders.
Two function have been provided, viz_eins plots the tensor network, and viz_contraction generate videos of an contraction order.
For more detailed usage, see the revised README.md.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 80.24691% with 32 lines in your changes missing coverage. Please review.

Project coverage is 92.83%. Comparing base (cc2295f) to head (3c3f608).
Report is 1 commits behind head on master.

Files Patch % Lines
ext/LuxorTensorPlot/src/viz_contraction.jl 80.30% 13 Missing ⚠️
src/visualization.jl 0.00% 8 Missing ⚠️
ext/LuxorTensorPlot/src/hypergraph.jl 81.57% 7 Missing ⚠️
ext/LuxorTensorPlot/src/viz_eins.jl 91.83% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   93.16%   92.83%   -0.33%     
==========================================
  Files          13       18       +5     
  Lines        1097     1270     +173     
==========================================
+ Hits         1022     1179     +157     
- Misses         75       91      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GiggleLiu
Copy link
Member

Please add some tests.

@ArrogantGao
Copy link
Contributor Author

ArrogantGao commented Aug 3, 2024

Added some dependency for the functions defined in src/visualization.jl and making sure they throw ArgumentError if the extension LuxorTensorPlot is not loaded.

@ArrogantGao
Copy link
Contributor Author

It is strange the the CodeCov seems not working correctly, the revised results are not uploaded properly.

{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2376s.', code='throttled')}

ext/LuxorTensorPlot/src/viz_contraction.jl Outdated Show resolved Hide resolved
ext/LuxorTensorPlot/src/viz_contraction.jl Outdated Show resolved Hide resolved
ext/LuxorTensorPlot/src/viz_contraction.jl Outdated Show resolved Hide resolved
ext/LuxorTensorPlot/src/viz_contraction.jl Outdated Show resolved Hide resolved
ext/LuxorTensorPlot/src/viz_contraction.jl Outdated Show resolved Hide resolved
test/visualization.jl Outdated Show resolved Hide resolved
@GiggleLiu
Copy link
Member

I made a few updates, please confirm the changes are reasonable.

@ArrogantGao
Copy link
Contributor Author

Thanks a lot for your help, I think all changes are reasonable and greatly simplified the code.

@GiggleLiu GiggleLiu merged commit c491c55 into TensorBFS:master Aug 4, 2024
1 check passed
@GiggleLiu
Copy link
Member

Nice, I just made a minor release here: JuliaRegistries/General#112375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants