Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to make some UI fixes to the website. #192

Closed
deepanshu-prajapati01 opened this issue Oct 29, 2024 · 0 comments
Closed

I want to make some UI fixes to the website. #192

deepanshu-prajapati01 opened this issue Oct 29, 2024 · 0 comments

Comments

@deepanshu-prajapati01
Copy link
Contributor

deepanshu-prajapati01 commented Oct 29, 2024

Issue Summary

I looked through the website and got to know there are a bunch of UI issues that needs to be fixed. For more details I have provided the screenshots of the problem.

Steps to Reproduce

  1. Head over to 'daily-quote' and 'notes' page and we can see there are 2 footers.

Daily Quotes Page

image

Notes Page

image

As we can see there are 2 footers. I would like to fix this issue.

  1. I want to fix this text in the Notes page when adding a note is says loading. Instead of this I wanna add a spinner for better visual.

image

  1. Also in the both endpoints, '/diary' and '/notes' after the adding the note, the text stays there as it is. It would be better practice to remove the text after adding a note successfully.

  2. I would love to improve the look of the '/guestbook'. Somehow it displays all the messages vertically. This will cause trouble when we have a lot of messages. So instead of aligning them vertically i will put them similarly as done in the '/notes' endpoint.

image

  1. In the src/app we can see all types of stuff lying there. This might create confusion to the developer in the future as our app grows. So I will put all the pages inside a folder (pages). Going through this approach will make our website more structured.
    PS: I would also fix all the import location related issues which will rise due to the changes made in path.

  2. In the GuestBook I found a great bug! Everything works fine in the app but incase we have no entries in our database, our app simply crashes because it fails to populate data.

For better understanding, I forked the repo and run in my machine, and I encounter this issue.

image

Additional Context:
Hey @TenzDelek please assign this issue to me with these labels-> gssoc-extd,hacktoberfest-accepted and level 2

@deepanshu-prajapati01 deepanshu-prajapati01 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant