From 89bf3a50f47beae9956089863585508ece62c787 Mon Sep 17 00:00:00 2001
From: Tercio Jose <terciob19@hotmail.com>
Date: Mon, 19 Aug 2024 13:19:05 -0300
Subject: [PATCH] Fixed Streamer plugin bug

---
 boot.lua                                      |  4 ++--
 plugins/Details_Compare2/Details_Compare2.lua | 13 +++++++++----
 plugins/Details_Streamer/Details_Streamer.lua | 11 +++++++++++
 3 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/boot.lua b/boot.lua
index 6891ec5fe..ccecf33fa 100644
--- a/boot.lua
+++ b/boot.lua
@@ -19,8 +19,8 @@
 		local addonName, Details222 = ...
 		local version, build, date, tvs = GetBuildInfo()
 
-		Details.build_counter = 12878
-		Details.alpha_build_counter = 12878 --if this is higher than the regular counter, use it instead
+		Details.build_counter = 12879
+		Details.alpha_build_counter = 12879 --if this is higher than the regular counter, use it instead
 		Details.dont_open_news = true
 		Details.game_version = version
 		Details.userversion = version .. " " .. Details.build_counter
diff --git a/plugins/Details_Compare2/Details_Compare2.lua b/plugins/Details_Compare2/Details_Compare2.lua
index 4fc86eb0c..0ecca695f 100644
--- a/plugins/Details_Compare2/Details_Compare2.lua
+++ b/plugins/Details_Compare2/Details_Compare2.lua
@@ -1,11 +1,16 @@
 
 do
+	local _
 	local Details = Details
+
 	if (not Details) then
 		print("Details! Not Found.")
 		return
 	end
 
+	---@type detailsframework
+	local detailsFramework = DetailsFramework
+
 	local CONST_COMPARETYPE_SPEC = 1
 	local CONST_COMPARETYPE_SEGMENT = 2
 
@@ -150,9 +155,6 @@ do
 	--> create a plugin object
 	local compareTwo = Details:NewPluginObject("Details_Compare2", _G.DETAILSPLUGIN_ALWAYSENABLED)
 
-	---@type detailsframework
-	local detailsFramework = DetailsFramework
-
 	--> set the description
 	compareTwo:SetPluginDescription("Replaces the default comparison window on the player breakdown.")
 
@@ -1932,12 +1934,15 @@ do
 				newComparisonFrame.titleIcon = detailsFramework:CreateTexture(newComparisonFrame)
 				newComparisonFrame.titleIcon:SetPoint("topleft", newComparisonFrame, "topleft", 0, comparisonFrameSettings.playerNameYOffset)
 
-				--player name shown above the scrolls
+				--player name or segment name shown above the scrolls
 				---@type df_label
 				newComparisonFrame.titleLabel = detailsFramework:CreateLabel(newComparisonFrame, "")
 				newComparisonFrame.titleLabel:SetPoint("left", newComparisonFrame.titleIcon, "right", 2, 0)
 				newComparisonFrame.titleLabel.fontsize = comparisonFrameSettings.playerNameSize
 
+				--combat selector dropdown
+				--todo: create a dropdown to select the combat
+
 				--grandient texture above the comparison frame
 				local gradientTitle = detailsFramework:CreateTexture(newComparisonFrame, {gradient = "vertical", fromColor = {0, 0, 0, 0.25}, toColor = "transparent"}, 1, 16, "artwork", {0, 1, 0, 1})
 				gradientTitle:SetPoint("bottomleft", newComparisonFrame, "topleft", 0, 0)
diff --git a/plugins/Details_Streamer/Details_Streamer.lua b/plugins/Details_Streamer/Details_Streamer.lua
index ece3e7668..0b8895217 100644
--- a/plugins/Details_Streamer/Details_Streamer.lua
+++ b/plugins/Details_Streamer/Details_Streamer.lua
@@ -61,6 +61,17 @@ local iconSize = 16
 --default icon for an attack on a monster
 local defaultAttackIcon = [[Interface\CURSOR\UnableAttack]]
 
+local GetSpellInfo = GetSpellInfo
+
+if (C_Spell and C_Spell.GetSpellInfo) then
+	GetSpellInfo = function(spellId)
+		local spellInfo = C_Spell.GetSpellInfo(spellId)
+		if (spellInfo) then
+			return spellInfo.name, _, spellInfo.iconID
+		end
+	end
+end
+
 local function CreatePluginFrames()
 	--shortcut for details fade function
 	local fader = Details.FadeHandler.Fader