Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No notice sent when we kill a process in order to cancel the test run #54

Open
CharliePoole opened this issue Oct 23, 2024 · 0 comments
Open

No notice sent when we kill a process in order to cancel the test run #54

CharliePoole opened this issue Oct 23, 2024 · 0 comments
Assignees
@CharliePoole
Labels
Bug Something isn't working as expected. High Priority High priority issue
Milestone
2.1.1

Comments

@CharliePoole
Copy link
Contributor

CharliePoole commented Oct 23, 2024 •
edited
Loading

Because no notice is sent, the GUI can't wait for a notice without risking a hang. In most cases, this seems to work but it appears that there could be a race condition in certain cases. We should send a notice that the run is complete.

@rowo360 @MartinZec This issue is blocking for TestCentric/testcentric-gui#1144.

NOTE: I believe that once an end of run notice is received, the engine will handle generation of notices for any in-process tests. However, that remains to be seen (and tested).
@CharliePoole CharliePoole added Bug Something isn't working as expected. High Priority High priority issue labels Oct 23, 2024
@CharliePoole CharliePoole self-assigned this Oct 23, 2024
@CharliePoole CharliePoole added this to the 2.1.1 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CharliePoole CharliePoole

Labels
Bug Something isn't working as expected. High Priority High priority issue
Projects
None yet
Milestone
2.1.1
Development

No branches or pull requests
1 participant
@CharliePoole