Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schematic\Entry::jsonSerialize() should be compatible with JsonSerializable::jsonSerialize(): mixed #13

Open
trejjam opened this issue Jun 25, 2022 · 0 comments
Open

Schematic\Entry::jsonSerialize() should be compatible with JsonSerializable::jsonSerialize(): mixed #13

trejjam opened this issue Jun 25, 2022 · 0 comments
Assignees
@Tharos

Comments

@trejjam
Copy link

trejjam commented Jun 25, 2022

Hi,
I am using your library in my own library. I run tests also against PHP8.1. I have an issue with an override of Schematic\Entry::jsonSerialize() as you can see here: https://github.com/trejjam/mailchimp/runs/7054121857#step:11:25

What is a solution which will suit you? Update signature, or define #[\ReturnTypeWillChange] ignoring attribute?
@Tharos Tharos self-assigned this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tharos Tharos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tharos @trejjam