Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow data modification #15

Open
miskovicm opened this issue Apr 13, 2023 · 0 comments
Open

Allow data modification #15

miskovicm opened this issue Apr 13, 2023 · 0 comments

Comments

@miskovicm
Copy link

miskovicm commented Apr 13, 2023 •
edited
Loading

Hello,

Entries are read-only, which is clearly stated in documentation.

What do you think about marking following \Schematic\Entry variables as protected?

  • $data
  • $entriesClass

This way I can extend class and update values without generating new object for each update.

Would you even consider this type of change?
Are there any potential drawbacks?

Thanks in advance for your answer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miskovicm