Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brinks: Add order on subscription renewal #115

Open
brettski opened this issue Nov 4, 2021 · 0 comments
Open

Brinks: Add order on subscription renewal #115

brettski opened this issue Nov 4, 2021 · 0 comments
Assignees
Labels

Comments

@brettski
Copy link
Contributor

brettski commented Nov 4, 2021

Handling subscription renewals is not complete.
Currently bouncer/brinks is listening for and handling invoice.paid webhooks form stripe. When the invoice paid payload contains a new subscription end date this information is updated on a member's record.

What is missing

  • Add an order for the subscription update. This is very important as the order table is used by bouncer to verify that a stripe event has not already been handled (event id).
    • A difficulty with creating an order, is that order's are event-based, and there is no event aligned with this renewal. So this needs to be figured out.
  • Determine if we are to add an allocation for the payment. The issue here being that there was no product purchased, it was a renewal of a subscription.
    • The ui is okay with no order allocation off of an order
    • What are we losing by not having the allocation there?
    • To add an allocation we'll need to set a constant for the product code to use.
@brettski brettski added the brinks label Nov 4, 2021
@brettski brettski self-assigned this Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant